Ticket #4712 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

ConjoinWorkspaces produces big gap in spectra when they don't overlap

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

With CheckOverlapping=False, even when the spectrum numbers do not overlap, they are changed. They should only be fixed if they overlap and CheckOverlapping=False

Load(Filename=r'CNCS_7860_event.nxs',OutputWorkspace='CNCS_7860_event')

CropWorkspace(InputWorkspace='CNCS_7860_event',OutputWorkspace='CNCS_7860_event_top',EndWorkspaceIndex='1000')
CropWorkspace(InputWorkspace='CNCS_7860_event',OutputWorkspace='CNCS_7860_event_bottom',StartWorkspaceIndex='1001',EndWorkspaceIndex='2000')

ConjoinWorkspaces('CNCS_7860_event_top','CNCS_7860_event_bottom', CheckOverlapping=False)

This is a problem for the ISIS C2E which currently expects the monitors to be in with the data

Change History

comment:1 Changed 9 years ago by Martyn Gigg

Refs #4712. Fix ConjoinWorkspaces when spectra don't overlap

The spectrum numbers are only "fixed" if they don't not already overlap.

Changeset: f5a886eeb25bf63ba1831ca5865cb1128accf522

comment:2 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 9 years ago by Martyn Gigg

Refs #4712. Fix ConjoinWorkspaces when spectra don't overlap

The spectrum numbers are only "fixed" if they don't not already overlap.

Changeset: f5a886eeb25bf63ba1831ca5865cb1128accf522

comment:6 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to closed

Confirmed that spectrum numbers are not changed when running the script above, and that they were before the changeset above. If the spectrum numbers do overlap, and CheckOverlapping is False, then renumbering does take place - with a big gap for some reason.

The wiki is out of date on this algorithm. I will try and update it to the best of my knowledge.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5559

Note: See TracTickets for help on using tickets.