Ticket #4720 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

NormaliseToMonitor needs to support events

Reported by: Martyn Gigg Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Mathieu Doucet

Description

Hi Nick,

I am having issues with NormalizeToMonitor from an eventmode data. I am reading event workspace (that creates 2 wk: data and monitors), rebinning both, then extracting a single spectrum (still have to do that as far as I can see, I reported that ages ago) and normalizing the data. This used used to work before but now I get this : Error in execution of algorithm NormaliseToMonitor: EventWorkspace::dataY cannot return a non-const array: you can't modify the histogrammed data in an EventWorkspace!

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Janik Zikovsky

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #4720: NormaliseToMonitor preserves events

Changeset: 6fc6962a7371ab82265821cca253df695ebe4466

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4720: NormaliseToMonitor preserves events

Changeset: 8f0aa088a13c3d6b4bbc49b60e2282dd69cfcabe

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from assigned to accepted

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: someone who knows how this algorithm should operate in detail should test this. I only applied the exact same normalisation to the event data (see the change log) using the EventList divide() method.

comment:6 Changed 8 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:7 Changed 8 years ago by Mathieu Doucet

  • Status changed from verifying to closed

Seems to work as advertised. I didn't quite understand why this didn't just give the same result as a simple divide but I assume that was the intention.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5567

Note: See TracTickets for help on using tickets.