Ticket #4738 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Redefine 0 and 1 in SpecialWorkspace2D

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Detector.isMasked() usage wins 0/false - keep data 1/true - delete data

SpecialWorkspace2D (will be when used as a masking workspace) 0/false - keep data 1/true - delete data

The change of definition will affect LoadMaskingFile and MaskDetectors.

Change History

comment:1 Changed 9 years ago by Wenduo Zhou

Implement the redefition of masking. Refs #4738.

In the latest definition of masking workspace, 0 and 1 are defined as not masking and masking the workspace, respectively. The following codes are affected by the swtich of the definition of 0 and 1 on masking or not.

Changeset: c809adeff4155954f3d83d651ce68c06805579cf

comment:2 Changed 9 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Vickie Lynch

Refs #4738 fix masking mistakes

Changeset: 7e13e8d98ef24d4c702c6204d49ee855f1dd63d4

comment:5 Changed 9 years ago by Vickie Lynch

Refs #4738 change notice to debug in FindPeaks

Changeset: 286dfab6a707a5af7bd3f2e961c24db4d3e1044b

comment:6 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Confirmed that MaskWorkspace uses 1 to mark masked detectors.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5585

Note: See TracTickets for help on using tickets.