Ticket #4742 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MantidPlot identifies PV

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.1
Component: VATES Keywords:
Cc: reuterma.ornl.gov Blocked By:
Blocking: Tester: Michael Reuter

Description

Background: Our tweaked distribution of PV 3.10.1, contained a different default for a CPack flag, which allowed users to put PV into the System or User Path. Without this, MantidPlot does not know where the PV libraries are.

Moving forward, we do not want to rely on our patched PV version #4741 . As part of the Mantid first-time configuration, allow users to point to the location of PV. This would be similar to our default facility/instrument dialog. One of the advantages of doing this is that users could have many different versions of PV on their system. We would also be able to reduce most of the environmental variables that we set.

Change History

comment:1 Changed 9 years ago by Owen Arnold

refs #4742. Fix missing header include.

Changeset: 90eb7e74b7208ab15f0b4b523dd99983b5a0fac1

comment:2 Changed 9 years ago by Owen Arnold

refs #4742. Fix missing header include.

Changeset: e76ac0f3a24c2e170c098a78fa17fd4c18de63e2

comment:3 Changed 9 years ago by Owen Arnold

Missing commits ended up on #4741

comment:4 Changed 9 years ago by Owen Arnold

refs #4742. Header include error fixed.

Changeset: 4119021160d521c92b66d3b26585e7b59336c36a

comment:5 Changed 9 years ago by Owen Arnold

refs #4742. Fix linux error with Qt includes on dialog.

Changeset: 3fb13b56826d3a6501456129e8e59d3bedbdefae

comment:6 Changed 9 years ago by Owen Arnold

refs #4742. Remove from ApplicationWindow.

Changeset: 73f73727fc25c8ee953b8ef3295c5a3eda7bbc39

comment:7 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:8 Changed 9 years ago by Owen Arnold

refs #4742. Skip if args are -xq

Changeset: 0392c6d8e10aa043cd2e119880e893c3400e86ca

comment:9 Changed 9 years ago by Owen Arnold

refs #4742. Pause. Investigate Linux issue.

Changeset: a84b0d45e0abf01d27ef4734ea09a72f985da7fc

comment:10 Changed 9 years ago by Owen Arnold

refs #4742. Windows only

Changeset: 6ee79d22cb5575a471b242465146c890fa253a07

comment:11 Changed 9 years ago by Owen Arnold

In the above, changed to be windows only because for other platforms setting the library path at runtime does not work.

Discussed this with Martyn and we'll need to come up with another solution for these platforms:

  • In InstallPV.sh, set the LD_LIBRARY_PATH in some manner.
  • Can we do something for the redhat packages?

comment:12 Changed 9 years ago by Owen Arnold

refs #4742. Mac error fix

Changeset: 76508682da92b340c66d212f2dba21ffc0ccfac3

comment:13 Changed 9 years ago by Owen Arnold

refs #4742. Fix path error

Changeset: 4cdff30163e18507467c18548287dc1ed7891521

comment:14 Changed 9 years ago by Russell Taylor

Clear linux compiler warning. Re #4742.

Changeset: 9b3e02444a839fd07d499f26e1b4e8c95bf79b4e

comment:15 Changed 9 years ago by Russell Taylor

Clear linux compiler warning. Re #4742.

Changeset: 9b3e02444a839fd07d499f26e1b4e8c95bf79b4e

comment:16 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Just tested this out in the following steps:

  1. Create a clean user account on windows
  2. Make new user admin and then switch to that account
  3. Install PV, Mantid and Mantid_Vates off the download page
  4. Log out and then revoke admin rights on the new account*
  5. Log back into the new account and start up Mantid Plot
  6. Point the dialog at the PV library folder c:/Program Files(x86)/paraview/bin and click SET
  7. Should be possible to visualise MDWorkspaces using the VSI now

*By revoking the admin rights we can be confident that* runtime modifications to the user PATH will work no mater what the user role is.

Tester could perform the same checks as part of the test procedure.

comment:17 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:18 Changed 8 years ago by Michael Reuter

I think this has been made obsolete by #5103.

comment:19 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

Owen has ironed all the bugs out and things work now.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5589

Note: See TracTickets for help on using tickets.