Ticket #4750 (closed: fixed)
Better Progress Reporting
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
Generating a vtkDataSet from a MDWorkspace can take some time. Our progress reporting to PV should include the time taken to do this, as well as the time spent running the algorithm via the presenter.
Each vtk..Factory in the VatesAPI must be responsible for providing this information.
Change History
comment:2 Changed 9 years ago by Owen Arnold
refs #4750. Stage 1. ProgressAction owns message now
Changeset: 260773ec9d2f4142b502c466483c4c522a1e3e8c
comment:3 Changed 9 years ago by Owen Arnold
refs #4750. Stage 2. Create refactored to take ProgressAction.
Changeset: 4fa3d0bd97f5a6043da27f734ddf769d8443179b
comment:4 Changed 9 years ago by Owen Arnold
refs #4750. Mock up ProgressAction to verify proper reporting.
Changeset: c675fd25839181ff76eb6d0ef1118f12f526f6fa
comment:5 Changed 9 years ago by Owen Arnold
refs #4750. Wire up to PV plugins.
Changeset: e29419eba66a98ffe9d3de5a078bdab151049710
comment:6 Changed 9 years ago by Owen Arnold
refs #4750. Fix warnings.
Changeset: b1501198e56655e4da5c670c30d011788bbcf58d
comment:7 Changed 9 years ago by Owen Arnold
refs #4750. Stage 1. ProgressAction owns message now
Changeset: 260773ec9d2f4142b502c466483c4c522a1e3e8c
comment:8 Changed 9 years ago by Owen Arnold
refs #4750. Stage 2. Create refactored to take ProgressAction.
Changeset: 4fa3d0bd97f5a6043da27f734ddf769d8443179b
comment:9 Changed 9 years ago by Owen Arnold
refs #4750. Mock up ProgressAction to verify proper reporting.
Changeset: c675fd25839181ff76eb6d0ef1118f12f526f6fa
comment:10 Changed 9 years ago by Owen Arnold
refs #4750. Wire up to PV plugins.
Changeset: e29419eba66a98ffe9d3de5a078bdab151049710
comment:11 Changed 9 years ago by Owen Arnold
refs #4750. Fix warnings.
Changeset: b1501198e56655e4da5c670c30d011788bbcf58d
comment:12 Changed 9 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester:
- Code inspection. vtkDataSetFactory::create should take a reference to a ProgressAction object. And do something with it.
- Can also rebin a MDWorkspace to a very fine level, and select 'No Thresholding' in the PV rebinning filter, which should mean that drawing is a more expensive operation. When executing this, the first set of reporting should be tagged 'rebinning...', after which there will be a rapid 'drawing...' step.
comment:13 Changed 8 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
comment:14 Changed 8 years ago by Janik Zikovsky
- Status changed from verifying to verify
- Tester Janik Zikovsky deleted
I can't seem to get this to work (on RHEL6) but perhaps I'm using the wrong version of paraview??
Perhaps someone with a clean install can try this...
comment:15 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:16 Changed 8 years ago by Michael Reuter
- Status changed from verifying to closed
Rebinning a workspace finely does report the correct steps in the progress bar.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5597
