Ticket #4751 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Consistency in VatesAPI

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.1
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Owen Arnold) (diff)

Clean up badly needed. Items to be dealt with.

  • Class names need to be made consistent. especially those using vtk..Factory
  • Unused or duplicate code needs to be dealt with

None of these changes should break any of the existing functionality, but since we are starting to reduce the effort spent on visualisation, we need to leave the code in a good state. The next coding activities here may well be maintenance ones.

  • Also Remove methods pertaining to VISIT

Change History

comment:1 Changed 9 years ago by Owen Arnold

  • Priority changed from minor to major
  • Description modified (diff)

comment:2 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Owen Arnold

refs #4751. Remove old type

Changeset: 5d0fd3c4b13222f007f3f2187d15952c12619448

comment:4 Changed 9 years ago by Owen Arnold

refs #4751. Delete unnecessary pure virual methods.

Changeset: b3340b80ba43642c2e0998c2ea2ef18fcda246e8

comment:5 Changed 9 years ago by Owen Arnold

refs #4751. Major refactoring. OneStepCreate introduced

Changeset: 9944c8d1e216864f59ac710c63e70fab714ba174

comment:6 Changed 9 years ago by Owen Arnold

refs #4751. Refactoring. Don't use box controller

Changeset: 46d44919f05f1b1f19762edbcf84d75f00881810

comment:7 Changed 9 years ago by Owen Arnold

refs #4751. Refactoring. Better type names.

Changeset: 46ea563c3d0dc3db532efe5595aa6bd9caa92311

comment:8 Changed 9 years ago by Owen Arnold

refs #4751. Refactoring. Rename files.

Changeset: b2d2c3d2790a74986ec2aa0e170db7ab5d0cf56a

comment:9 Changed 9 years ago by Owen Arnold

refs #4751. Refactoring. Don't use box controller

Changeset: 46d44919f05f1b1f19762edbcf84d75f00881810

comment:10 Changed 9 years ago by Owen Arnold

refs #4751. Refactoring. Better type names.

Changeset: 46ea563c3d0dc3db532efe5595aa6bd9caa92311

comment:11 Changed 9 years ago by Owen Arnold

refs #4751. Refactoring. Rename files.

Changeset: b2d2c3d2790a74986ec2aa0e170db7ab5d0cf56a

comment:12 Changed 9 years ago by Owen Arnold

  • Description modified (diff)

comment:13 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

As this ticket relates to refactoring work. The only methods of testing are a code inspection + checking that everything still works.

comment:14 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:15 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

I use this API quite heavily in the VSI and things are working just fine there, so I call this OK.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5598

Note: See TracTickets for help on using tickets.