Ticket #4765 (closed: fixed)
Have the code that determines the patch version consider only annotated tags
Reported by: | Russell Taylor | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | trivial | Milestone: | Release 2.1 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Jose Borreguero |
Description
A very minor change to the code will mean that only git annotated tags reset the patch part of the version counter. This will allow us to use git lightweight for other things if we ever need or want to.
Change History
comment:2 Changed 9 years ago by Russell Taylor
Version number counting only looks for annotated tags. Re #4765.
The code that determines the 'patch' version number uses 'git describe'. This change means that git lightweight tags are not considered here, so we can use them if needed without resetting the version number.
Changeset: 8dbfaf2deaefab9febdc764b61728ad1629f0437
comment:3 Changed 9 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
To test:
- Build Mantid and note the version number
- Create a lightweight tag (git tag tagname), run cmake (important) and note that the version number has not changed.
- Create an annotated tag (git tag -a anothertagname), run cmake (important) and note that the patch version number has gone to zero.
- Remember to delete the tags (git tag -d tagname) before pushing to github!
Note: See
TracTickets for help on using
tickets.