Ticket #4773 (closed: fixed)
Speed up GetDetOffsetsMultiPeaks
| Reported by: | Peter Peterson | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Vickie Lynch |
Description
In its current form, with 10 peaks specified in CalibrateRectangularDetectors it takes 42 minutes to run.
Change History
comment:1 Changed 9 years ago by Peter Peterson
- Owner set to Peter Peterson
- Status changed from new to accepted
comment:2 Changed 9 years ago by Peter Peterson
Refs #4773. Small efficiencies to help object creation.
This won't make much of a difference unless you do lots of fits.
Changeset: 9b444f3a1ef6b758febcd141cb92c3d8a813ea43
comment:3 Changed 9 years ago by Peter Peterson
Refs #4773. More small changes to help things out.
Changeset: 2ccee66240cebbc6ebacc4001c3342a75cad8b81
comment:4 Changed 9 years ago by Peter Peterson
Refs #4773. More efficiencies improvements.
Changed parameter types to be ArrayProperty<double> where possible and modified things for const correctness and pass by reference when possible.
Changeset: f8b46b224a21435fa4937db729e9468dc2c0e187
comment:5 Changed 9 years ago by Peter Peterson
Refs #4773. Fixing loop size
Changeset: 087825f9e388797f7f8df66f73b9e7f862427b2e
comment:6 Changed 9 years ago by Peter Peterson
Refs #4773. Fixing unit tests.
Changeset: 2fd0faae7a649d159e17b3c64334fed0593db638
comment:7 Changed 9 years ago by Vickie Lynch
Refs #4773 only call FindPeaks once per spectra
Changeset: 1d0bb52c479dbb699ffbede68b80bb5f66b29c9b
comment:8 Changed 9 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
It does its job in 4 minutes now. Partially due to Roman refactoring bits of curve fitting, but mostly due to Vickie's change.
comment:9 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:10 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to closed
Calibration is faster now.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5620
