Ticket #4776 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Clear memory leaks in the CurveFitting library

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Jose Borreguero

Description

There are plenty.

Change History

comment:1 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

Remove memory leaks directly coming from CurveFitting unit test code.

Clearing the trees so I can see the wood. Re #4776. Why put things on the heap when you don't need to?

Changeset: 7a4a8305e949150c5723aa5b2423fd3355d21ae3

comment:3 Changed 9 years ago by Russell Taylor

Indentation fixed & dead code removal. Re #4776.

No functional changes.

Changeset: 7773776debf7760572c173c38d96e2e229bda88d

comment:4 Changed 9 years ago by Russell Taylor

Clear memory leaks in BivariateNormal. Re #4776.

These are the ones that show up when running valgrind on the unit test. This is still very risky code through so I can't be sure there's no more leak candidates.

Changeset: dd23f48c1eb526a28c2a80424c494423ae052d44

comment:5 Changed 9 years ago by Russell Taylor

Clear some memory leaks in GenericFit.cpp. Re #4776.

Mainly by using shared pointers and the DynamicFactory::create() method instead of createUnwrapped().

Changeset: f245acb56f2a06b6c36d3ef6205fa43b422181ab

comment:6 Changed 9 years ago by Russell Taylor

Partial revert to fix mac build. Re #4776.

This code is definitely not exception-safe though.

Changeset: 9392d8a4d4097b7ae5443fd5895787200ebebe8a

comment:7 Changed 9 years ago by Russell Taylor

Fix memory leak in cxxtest code. Re #4776.

Changeset: fa3ddd50198d46d00b67525bf735c035752a15e5

comment:8 Changed 9 years ago by Russell Taylor

Clear a couple of CurveFitting memory leaks. Re #4776.

Changeset: 11f07556f61006dc7a09fd9b983872c220d81565

comment:9 Changed 9 years ago by Russell Taylor

A few more memory leaks cleared. Re #4776.

Changeset: 71145b17f76c1e3ee1ed0ffc35b44b2bb70d6e15

comment:10 Changed 9 years ago by Russell Taylor

Put back BivariateNormal memory fixes. Re #4776.

Changeset: 7c5ab04371f204901ef03c75577727bfda4eb6c4

comment:11 Changed 9 years ago by Russell Taylor

More memory fixes. Re #4776.

Changeset: 3e4917d5cb10a0d22982331bfe10aea67455a94b

comment:12 Changed 9 years ago by Russell Taylor

Re #4776. Clear some memory leaks.

Changeset: ff239bdb93c54db0817c3196939180519475ccea

comment:13 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

As of today, valgrind shows zero memory leaks on running the entire CurveFittingTest executable (even when including some that are temporarily commented out at this time).

comment:14 Changed 8 years ago by Jose Borreguero

  • Status changed from verify to verifying
  • Tester set to Jose Borreguero

comment:15 Changed 8 years ago by Jose Borreguero

  • Status changed from verifying to closed

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5623

Note: See TracTickets for help on using tickets.