SaveNexusProcessed output extra instr info

[Anders Markvardsen]

There is a request for Mantid to populate the Nexus ‘instrument’ field, when SaveProcessedNexus is called, with information that a none Mantid program may use sometime in the future.

One starting suggestion is to add the following entries to the ‘instrument’ NXinstrument folder:

distance - in unit of meter polar_ angle - in units of degrees azimuthal_angle - in units of degrees detector_number - storing detector IDs

where all the above are 1D arrays of length = number of detectors....

Also add solid_angle.

Names of nexus are listed ​http://download.nexusformat.org/doc/html/ClassDefinitions-Base.html#NXdetector

[Karl Palmen]

Is this required only for Nexus files saved from a Matrix workspace?

[Karl Palmen]

Early work on adding instrument data for re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 58c37cd8b64c4fbfb5886f0cb83bf3328e417679

[Karl Palmen]

Get Detector IDs and Phi Angles re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 88ad79dbbd0ed87e343185cd1cf680c243d02cdf

[Karl Palmen]

Added data including Monitors re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 1d5433f0cf1652b42c7b4fde34d8d71c21586e87

[Karl Palmen]

Added polar angle and changed names re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9095d2333e717f9bdb798c02d1a46358fec4310d

[Karl Palmen]

Early work on adding instrument data for re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e218a564e629c52a245e5a99d2f332bc95212df4

[Karl Palmen]

Get Detector IDs and Phi Angles re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 99be1683f7336177a4c957e18880457a0e09a677

[Karl Palmen]

Added data including Monitors re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e47f127d668b58b67bbcafb2cbfe41dda167951a

[Karl Palmen]

Added polar angle and changed names re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 17265f0ce984ef4e26778f0c8ac19e62d29cb0e9

[Karl Palmen]

Show info for detectors and not monitors re #4781

Changeset: 62ac721c68f427eae3ce3f11ea56b387449e383e

[Karl Palmen]

Separate data for detectors and monitors re #4781

Also renamed new_group extra_data and made other groups all lowercase.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 635e3fd511635e8b912be720d73ca7eb75bdcde6

[Karl Palmen]

Added units and corrected some names re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 657eb657660da05a155296df2d369fd7c77386f4

[Karl Palmen]

Arranged data into physical_detectors and physical_monitors re #4781

Also removed the extra_data group and refactored code.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a1edeb1d2852e8a31cc2cfe8b8bc9ef9f4492eb5

[Russell Taylor]

I'm thinking that most of the code added here is in the wrong place - that it belongs in Instrument rather than ExperimentInfo. It may be that you want positions etc. after any parameters have been applied to the base instrument (and if not, I think that's what you're getting), but that should work fine if a parameterized instrument is created using getInstrument and acted upon.

At minimum multiple calls to getInstrument() should be avoided as they construct a whole new instrument every time.

[Karl Palmen]

Cast vector size to size_t for Isis Snowleopard re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ccc92bd6a85fab9083957092d0584d7155f835c1

[Karl Palmen]

Commented out number_of_detectors etc cos of Apple trouble re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a4347927538480495189849f539536e04e097d43

[Karl Palmen]

Interesting comment by Russell Taylor. I don't understand it fully and perhaps Anders could comment on it.

Perhaps, ExperminentInfo could create a copy of the instrument with one getInstument call an then refer to it later on.

[Russell Taylor]

Compiler warnings. Re #4781.

Changeset: deb3ade9c5c5fd685ecadc04b615e10283fe041f

[Karl Palmen]

Restore number_of_detectors etc with uint64_t cast re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Conflicts:

Code/Mantid/Framework/API/src/ExperimentInfo.cpp

Changeset: 5b57ddc2feee4615fcc2b59d12fd3c5ed9f3355c

[Karl Palmen]

Issues raised by Russell can be dealt with in a separate ticket.

[Karl Palmen]

Early work on adding instrument data for re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e218a564e629c52a245e5a99d2f332bc95212df4

[Karl Palmen]

Get Detector IDs and Phi Angles re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 99be1683f7336177a4c957e18880457a0e09a677

[Karl Palmen]

Added data including Monitors re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e47f127d668b58b67bbcafb2cbfe41dda167951a

[Karl Palmen]

Added polar angle and changed names re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 17265f0ce984ef4e26778f0c8ac19e62d29cb0e9

[Karl Palmen]

Show info for detectors and not monitors re #4781

Changeset: 62ac721c68f427eae3ce3f11ea56b387449e383e

[Karl Palmen]

Separate data for detectors and monitors re #4781

Also renamed new_group extra_data and made other groups all lowercase.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 635e3fd511635e8b912be720d73ca7eb75bdcde6

[Karl Palmen]

Added units and corrected some names re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 657eb657660da05a155296df2d369fd7c77386f4

[Karl Palmen]

Arranged data into physical_detectors and physical_monitors re #4781

Also removed the extra_data group and refactored code.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a1edeb1d2852e8a31cc2cfe8b8bc9ef9f4492eb5

[Karl Palmen]

Cast vector size to size_t for Isis Snowleopard re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ccc92bd6a85fab9083957092d0584d7155f835c1

[Karl Palmen]

Commented out number_of_detectors etc cos of Apple trouble re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a4347927538480495189849f539536e04e097d43

[Russell Taylor]

Compiler warnings. Re #4781.

Changeset: deb3ade9c5c5fd685ecadc04b615e10283fe041f

[Karl Palmen]

Restore number_of_detectors etc with uint64_t cast re #4781

Signed-off-by: Karl Palmen <karl.palmen@…>

Conflicts:

Code/Mantid/Framework/API/src/ExperimentInfo.cpp

Changeset: 5b57ddc2feee4615fcc2b59d12fd3c5ed9f3355c

[Russell Taylor]

Don't keep creating parameterised instruments. Re #4962, Re #4781.

Changeset: 663bd7edac0f2ae56b81e1bb0e21a437d2a1c988

[Russell Taylor]

Don't keep creating parameterised instruments. Re #4962, Re #4781.

Changeset: 663bd7edac0f2ae56b81e1bb0e21a437d2a1c988

[Roman Tolchenov]

Saved a workspace in Mantid processed format and was able to find all the new entries except solid_angle. According to Karl it was decided to exclude it. The entries were found in NXdetector class rather than NXinstrument

[Stuart Campbell]

This ticket has been transferred to github issue ​5628