Ticket #4783 (closed: fixed)
Clear memory leaks in algorithm init methods
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Wenduo Zhou |
Description
Just starting up MantidPlot shows up a good number of leaks occurring in Algorithm init() methods (which are all called, probably more than once, on startup).
Mainly this seems to be based on a lack of widespread knowledge that clone() only needs to be called on a validator if it's passed to more than property. Probably these should be shared pointers, but right now I'm just going to fix the leaks that show up.
Change History
comment:2 Changed 9 years ago by Russell Taylor
Clear memory leaks in algorithm's init() methods. Re #4783.
Changeset: d684dcc54a08723229f8918e8599731570f23f8e
comment:3 Changed 9 years ago by Russell Taylor
Clear leak of OrientedLattice in Sample. Re #4783.
Changeset: 9d112bab33a01c0cf681b5e192cac6d05dcb1112
comment:4 Changed 9 years ago by Russell Taylor
Clear remaining leaks in algorithm's init methods. Re #4783.
Changeset: 0232c81b04ed1fac9ce7681ada4c7efda2e02242
comment:5 Changed 9 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
To test, run "valgrind --leak-check=full" (or visual leak detector equivalent) on MantidPlot, closing the program as soon as it's completed startup, and search the output for anything coming from calling Algorithm::initialize().
