Ticket #4791 (closed: fixed)
Investigate using floats instead of doubles as coord_t
| Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | alex.buts@… | Blocked By: | |
| Blocking: | Tester: | Jose Borreguero |
Description (last modified by Janik Zikovsky) (diff)
Because this would reduce memory used by MDWorkspaces by approx 2.The "coord_t" typedef is currently defined as a double. Try to redefine it as a float, because this would reduce memory used by MDWorkspaces by approx 2.
Go through the code and make sure the proper casts are there, and squash warning for both situations.
Change History
comment:2 Changed 9 years ago by Janik Zikovsky
Refs #4791: prepare for testing coord_t = float
Reduce warnings and avoid errors
Changeset: f865dd257b86ca493fbc3d7cf0e93d9c13fee568
comment:3 Changed 9 years ago by Janik Zikovsky
Refs #4791: templated VMD could be set to use floats
Typedef for VMD points to the desired type.
Changeset: 98eb8fa5c9793b8bdcac8ae4ff7ab308f720f4a1
comment:4 Changed 9 years ago by Janik Zikovsky
Refs #4791 suppress more warnings
Changeset: 6c1a29bb939f6c59db3278230a7fa83531249835
comment:5 Changed 9 years ago by Janik Zikovsky
Refs #4791 win build fix attempt
Changeset: d01ec0fa070175569b5327fb393b85e71071489c
comment:6 Changed 9 years ago by Janik Zikovsky
refs #4791 fix win build?
Changeset: 8f9a0c03d69ca77fbfc4d1c10c55d26af629a5c1
comment:7 Changed 9 years ago by Janik Zikovsky
Refs #4791: fix build maybe
Changeset: 604bd42a0c75f3048e62f92eb0d9aa5acf536f3a
comment:8 Changed 9 years ago by Janik Zikovsky
Refs #4791: fix build maybe
Changeset: 8fcaa2360ffe88a894f3cb49cf3c5dabc0e72a35
comment:9 Changed 9 years ago by Janik Zikovsky
Refs #4791 using coord_t in more places
To reduce warnings when coord_t = float. Also, fix a warning #4473.
Changeset: 6f3494ac95f1c044e7f90dabc251497334660215
comment:10 Changed 9 years ago by Janik Zikovsky
Refs #4791 fix errors and warnings in test for coord_t = float
Changeset: 54f88c1a94bdf0d5e4df44384670836f68879060
comment:11 Changed 9 years ago by Janik Zikovsky
Refs #4791 all tests work with coord_t = float
Changeset: 907db4684c786b5480d79e82cc532ae2abbf0306
comment:12 Changed 9 years ago by Janik Zikovsky
Refs #4791 squash all warnings when coord_t=float
I think. Later I will replace c-style casts with c++ static_cast<coord_t>
Changeset: 740d83ac200d55494763630828c4baf13d2bbd9c
comment:13 Changed 9 years ago by Janik Zikovsky
Refs #4791 fix last test
Changeset: 2a21889b561267c5266c2d71af3d0f7a5499ecc6
comment:15 Changed 9 years ago by Janik Zikovsky
Refs #4791 use 0.123f instead of coord_t(0.123)
Because that is more readable
Changeset: d7c6f88a1e55c6c87318dc0403702c68d42b5679
comment:16 Changed 9 years ago by Janik Zikovsky
Refs #4791 use 0.123f instead of coord_t(0.123)
Because that is more readable
Changeset: 1966776ce6eea348a6a19d284590245c5dce86eb
comment:17 Changed 9 years ago by Janik Zikovsky
Refs #4791 use 0.123f instead of coord_t(0.123)
Because that is more readable
Changeset: efde066a3e31e1e93e76ef9a18d3784a4987449e
comment:18 Changed 9 years ago by Janik Zikovsky
Refs #4791: use static_cast instead of c-style cast
Changeset: 24a9e2e5b09f5f7f12152712076398057d87caf5
comment:19 Changed 9 years ago by Janik Zikovsky
Refs #4791: actually define coord_t as float to try it on
the other build systems
Changeset: 44a262680dba5d34d96dec3ea76c3571002fa7ed
comment:20 Changed 9 years ago by Janik Zikovsky
Refs #4791 load old MDEW .nxs files
and fix windows build I hope
Changeset: 1c7a6bd28341e9d2390fdad18518357b0036b5f9
comment:21 Changed 9 years ago by Janik Zikovsky
Refs #4791: fix SliceViewerPythonInterfaceTest
Changeset: fad00c2b7565a65aa8ed819331b9f81239221b37
comment:22 Changed 9 years ago by Janik Zikovsky
Refs #4791: add warning when loading old MDEW nxs file
Changeset: b3b265e2a10fa3f4bc369ff33070466089456ab4
comment:23 Changed 9 years ago by Janik Zikovsky
Refs #4791: make sure MDEvents are summed as doubles
to preserve precision
Changeset: 4888ce7b5915722b099a4643613199cfa61c38ca
comment:24 Changed 9 years ago by Janik Zikovsky
Refs #4791: Better code reuse. File-backed MDWS can save
to the older file format too. Added warning for detector IDs > 16 million for (possible) future generations of instruments
Changeset: 394db9f93c4827c9d1e5e20fab0c6fc191ab0b09
comment:25 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
Note to testers: this is not very easy to test. A code review would be good. Check that it works with older MDEventWorkspace .nxs files (that were saved in doubles).
comment:26 Changed 9 years ago by Janik Zikovsky
Refs #4791: make sure MDEvents are summed as doubles
to preserve precision
Changeset: 4888ce7b5915722b099a4643613199cfa61c38ca
comment:27 Changed 9 years ago by Janik Zikovsky
Refs #4791: Better code reuse. File-backed MDWS can save
to the older file format too. Added warning for detector IDs > 16 million for (possible) future generations of instruments
Changeset: 394db9f93c4827c9d1e5e20fab0c6fc191ab0b09
comment:28 Changed 8 years ago by Jose Borreguero
- Status changed from verify to verifying
- Tester set to Jose Borreguero
comment:30 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5638
