Ticket #4804 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Speed up LoadEventNexus initialization

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Jose Borreguero

Description


Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

Starting point: 

 1.0734 s, CPU 1.02 to createSpectraMapping()
 2.4822 s, CPU 1.02 to padSpectra()
 2.0328 s, CPU 1.02 to getDetectorIDToWorkspaceIndexMap
 5.2739 s, CPU 1.02 to makeMapToEventLists

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4804 padSpectra() parallelized = 0.8 seconds

instead of 2.4

Changeset: 7905a6db4d763ab464cebd0a18fdf3f390eb3b7d

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #4804: getSpectrumToWorkspaceIndexVector method

Changeset: fc2b85e3224c7c90a14e94d6301d0a03d5032c29

comment:5 Changed 9 years ago by Janik Zikovsky

Refs #4804: LoadEventNexus 17sec->8 sec for TOPAZ

Thanks to using a vector instead of a map and other speed ups

Changeset: 5e93090edd08b60216beb28aae3e4a37d5e0ee8a

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #4804: Tracking which detector IDs were hit removed

Gives a savings of 1.6 seconds (over all threads) in TOPAZ_3132 and does not aaffect results

Changeset: 71818621da8f9d9fd646871d3a8832ef8eb2b5fb

comment:7 Changed 9 years ago by Janik Zikovsky

Refs #4804 Load went from 14 to 5 seconds

(after loading the instrument once, for TOPAZ 3132 sample file). Speed up createSpectraMapping() slightly

Changeset: 0278380fc65235ded4611fa6fb4e59db36e3c65d

comment:8 Changed 9 years ago by Janik Zikovsky

Revert "Refs #4804: Tracking which detector IDs were hit removed"

This reverts commit 71818621da8f9d9fd646871d3a8832ef8eb2b5fb.

Changeset: c9660171f3940b531161318260c48b1a859ad356

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4804 only track used detector IDs when compressing

Otherwise it wastes time

Changeset: 71ff7be2177ca26b7d3e4f3511e2119d6c6a8655

comment:10 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

My new initialization times for TOPAZ are around: 

 1.0222 s, CPU 1.03 to createSpectraMapping()
 0.7614 s, CPU 4.47 to padSpectra()
 0.1195 s, CPU 6.03 to getDetectorIDToWorkspaceIndexVector
 0.1636 s, CPU 0.98 to makeMapToEventLists

So about 2 seconds instead of 10. Good!

comment:11 Changed 9 years ago by Janik Zikovsky

Refs #4804 possible windows fix

Changeset: 591e4f4ae8a86ebd5f693e567d173e25a1266282

comment:12 Changed 9 years ago by Janik Zikovsky

Refs #4804 padSpectra() parallelized = 0.8 seconds

instead of 2.4

Changeset: 7905a6db4d763ab464cebd0a18fdf3f390eb3b7d

comment:13 Changed 9 years ago by Janik Zikovsky

Refs #4804: getSpectrumToWorkspaceIndexVector method

Changeset: fc2b85e3224c7c90a14e94d6301d0a03d5032c29

comment:14 Changed 9 years ago by Janik Zikovsky

Refs #4804: LoadEventNexus 17sec->8 sec for TOPAZ

Thanks to using a vector instead of a map and other speed ups

Changeset: 5e93090edd08b60216beb28aae3e4a37d5e0ee8a

comment:15 Changed 9 years ago by Janik Zikovsky

Refs #4804: Tracking which detector IDs were hit removed

Gives a savings of 1.6 seconds (over all threads) in TOPAZ_3132 and does not aaffect results

Changeset: 71818621da8f9d9fd646871d3a8832ef8eb2b5fb

comment:16 Changed 9 years ago by Janik Zikovsky

Refs #4804 Load went from 14 to 5 seconds

(after loading the instrument once, for TOPAZ 3132 sample file). Speed up createSpectraMapping() slightly

Changeset: 0278380fc65235ded4611fa6fb4e59db36e3c65d

comment:17 Changed 9 years ago by Janik Zikovsky

Revert "Refs #4804: Tracking which detector IDs were hit removed"

This reverts commit 71818621da8f9d9fd646871d3a8832ef8eb2b5fb.

Changeset: c9660171f3940b531161318260c48b1a859ad356

comment:18 Changed 9 years ago by Janik Zikovsky

Refs #4804 only track used detector IDs when compressing

Otherwise it wastes time

Changeset: 71ff7be2177ca26b7d3e4f3511e2119d6c6a8655

comment:19 Changed 9 years ago by Janik Zikovsky

Refs #4804 possible windows fix

Changeset: 591e4f4ae8a86ebd5f693e567d173e25a1266282

comment:20 Changed 8 years ago by Jose Borreguero

  • Status changed from verify to verifying
  • Tester set to Jose Borreguero

comment:21 Changed 8 years ago by Jose Borreguero

  • Status changed from verifying to closed

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5651

Note: See TracTickets for help on using tickets.