Ticket #4810 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SANSMaskCommands test doesn't look right

Reported by: Martyn Gigg Owned by: Anders Markvardsen
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

The test_mask_line test is currently broken but it seems wrong anyway. It tests LINE masking on LOQ but the code for line masking only applies it to SANS2D.

This needs to be investigated and the test updated accordingly.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

Refs #4810. Disable test until it is checked that it is actually right

Changeset: 1c0a76b4ebce65705b99ad03461a6bd16c7e3d89

comment:2 Changed 9 years ago by Martyn Gigg

Refs #4810. Disable test until it is checked that it is actually right

Changeset: 1c0a76b4ebce65705b99ad03461a6bd16c7e3d89

comment:3 Changed 8 years ago by Anders Markvardsen

re-inserted sansmaskcommand test. re #4810

More specifically re-inserted test and added additional test

Changeset: 7c05c76329dd2cfccbe21d1a70bd20000bf3d8c8

comment:4 Changed 8 years ago by Martyn Gigg

More stable getComponentByName. Refs #4810

Changeset: 144ca2448336a81dbbf4a7e7aa9ce2ffc3c13755

comment:5 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:6 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: check updated code in sansmaskcommandtest.py

comment:7 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:8 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5657

Note: See TracTickets for help on using tickets.