Ticket #4814 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Port diagnose.py (mostly) into a C++ workflow algorithm

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: saviciat@… Blocked By:
Blocking: Tester: Andrei Savici

Description

Since the functionality is fairly reusable, create a workflow algorithm that will do most of the work. This will take one or two workspaces and output a MaskWorkspace. There will be options to run all of the following in the order they are listed.

  1. FindDetectorsOutsideLimits (always)
  2. MedianDetectorTest (if selected)
  3. DetectorEfficiencyVariation (only if two workspaces are specified)
  4. CreatePSDBleedMask (if selected)

Change History

comment:1 Changed 9 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 9 years ago by Peter Peterson

Refs #4814. FindeDetectorsOutsideLimits outputs a SpecialWorkspace2D.

Changeset: ebd70bc01e90d86cd36965d5d1100a7d4e079d46

comment:3 Changed 9 years ago by Peter Peterson

Refs #4814. Faster isMonitor implementation.

Much like isDetectorMasked, isMonitor removes the need to make temporary copies of objects.

Changeset: fc17b2bd10a410e08f82030b59cdb5277c3cb553

comment:4 Changed 9 years ago by Peter Peterson

Refs #4814. Fixed potential bug when instrument is null.

Changeset: 00066c1a2986c6d71da576cdbd89bb6bbc3b894a

comment:5 Changed 9 years ago by Peter Peterson

Refs #4814. Const correctness.

Changeset: e435bce66086958391b3179ca4ea0b59289228fb

comment:6 Changed 9 years ago by Peter Peterson

Refs #4814. CreatePSDBleedMask outputs a SpecialWorkspace2D.

Changeset: 26fc5c33fe42be054a824b772c0521c2a8f98ef0

comment:7 Changed 9 years ago by Peter Peterson

Refs #4814. DetectorEfficiencyVariation outputs SpecialWorkspace2D.

Changeset: 610b8066c541074f519501d2206f0ac45a490a7a

comment:8 Changed 9 years ago by Peter Peterson

Refs #4814. Using more efficient mask checking.

Changeset: e6d4c9518483f9ef14af3d920da3d87ac45cb49f

comment:9 Changed 9 years ago by Peter Peterson

Refs #4814. Removed debug print.

Changeset: b285d0810a69f897fac40465740d59c36279636d

comment:10 Changed 9 years ago by Peter Peterson

Refs #4814. Simplest conversion ever. Needs work.

Changeset: 330ce42a45626bf50bdd0b7885ec6af8855b4be2

comment:11 Changed 9 years ago by Peter Peterson

Refs #4814. Return value in a more correct manner.

Changeset: bfdf8209ed247f298a445ad5bff5ee39ae3a34f1

comment:12 Changed 9 years ago by Peter Peterson

Refs #4814. Added overload for isMonitor.

Changeset: 8b4ad1caa2768b6e95736520f7a9ee05a8fdd95f

comment:13 Changed 9 years ago by Peter Peterson

Refs #4814. Slightly more safe check.

Changeset: a57ac1ab934380e20c06a01ad5157edf45f9f55f

comment:14 Changed 9 years ago by Peter Peterson

Refs #4814. Using mask checking from the instrument.

Changeset: 00a743ad5d6e9457e8d30716f2702bf757da83b4

comment:15 Changed 9 years ago by Peter Peterson

Refs #4814. Fixing a bug found during MedianDetectorTest conversion.

Changeset: c410162a2d5742d27acc500ac1d15548a7a5e3ee

comment:16 Changed 9 years ago by Peter Peterson

Refs #4814. Got rid of the hack converting the output workspace.

Changeset: 50890629daa6267370339cff8c48aa5481a2d136

comment:17 Changed 9 years ago by Peter Peterson

Refs #4814. Parameter list is all set.

Changeset: cb47d2b1593137f1a1c21d8c131cab87848b1768

comment:18 Changed 9 years ago by Martyn Gigg

Refs #4814. Fix system tests.

Extract shouldn't clear the parameter map flags (broke SANS tests) and ExtractMask/MaskDetectors doesn't seem to give the right answer when used with detector IDs. Switched to using MaskWorkspace directly

Changeset: 1002d53dfd6f294d534016c4b4fc9ea39f2976d6

comment:19 Changed 9 years ago by Peter Peterson

Refs #4814. Got the test working again and modernized a bit.

Changeset: f691dda458561ae3245e380c0b7f4b26154873e1

comment:20 Changed 9 years ago by Peter Peterson

Refs #4814. Now runs all four dynamic detector tests.

Changeset: 128dfd869431942352f5048b75a009c782ca5eaa

comment:21 Changed 9 years ago by Peter Peterson

Refs #4814. Fixing up the progress bar reporting.

Changeset: d689c4c9f73215ec41827cc06d1bf576a35fc043

comment:22 Changed 9 years ago by Peter Peterson

Refs #4814. Set the category.

DetectorDiagnostics is now a Workflow/Diagnostics algorithm and all of its children are Diagnostics algorithms.

Changeset: f2be786c5966a8fa45d82d2e347fdf37ab504587

comment:23 Changed 9 years ago by Martyn Gigg

Refs #4814. Fix system tests.

Changeset: 49c9ff87572a853c12edca3a8419b72f990e7ec5

comment:24 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

The masking bit isn't going to get properly reset without breaking things so I'm just giving up on it. This ticket is done.

comment:25 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:26 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

For median detector test, the solid angle option is not available. Created Ticket #5191

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5661

Note: See TracTickets for help on using tickets.