Ticket #4815 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Improve performance of LoadInstrument (in particular for BASIS)

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 2.0.2
Component: Mantid Keywords:
Cc: 8oz@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Having lots of parameters in the IDF seems to cause a significant degradation in performance of LoadInstrument.

Janik: Just cc'ing you as Pete said you were also looking at LoadInstrument performance.

Change History

comment:1 Changed 9 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Stuart Campbell

Speed up creating list of elements with parameters. refs #4815

Instead of looping over the NodeList of elements with "parameter" as the name, it is quick to loop over all elements and check the name.

Changeset: 362682029afb39deabdf659a54a111f2314ca216

comment:3 Changed 9 years ago by Stuart Campbell

Added Comment. refs #4815

Changeset: 01171350e34b99b9e99e890a92febf5a8a6ba4a2

comment:4 Changed 9 years ago by Stuart Campbell

Testing performance by hand running LoadEmptyInstrument() time taken has decreased from 49 sec to 2.5 secs.

Looking at the performance tests... runtime/iter has gone from 343.149 to 5.837. (I have attached the plot.)

Changed 9 years ago by Stuart Campbell

comment:5 Changed 9 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Stuart Campbell

Speed up creating list of elements with parameters. refs #4815

Instead of looping over the NodeList of elements with "parameter" as the name, it is quick to loop over all elements and check the name.

Changeset: 362682029afb39deabdf659a54a111f2314ca216

comment:7 Changed 9 years ago by Stuart Campbell

Added Comment. refs #4815

Changeset: 01171350e34b99b9e99e890a92febf5a8a6ba4a2

comment:8 Changed 9 years ago by Stuart Campbell

Speed up creating list of elements with parameters. refs #4815

Instead of looping over the NodeList of elements with "parameter" as the name, it is quick to loop over all elements and check the name.

Changeset: 70024ac882783fa3d274e5d5d7c063a4ffef1159

comment:9 Changed 9 years ago by Stuart Campbell

Added Comment. refs #4815

Changeset: 91711fae1f5a19578840fca750736a2e6fa86658

comment:10 Changed 9 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.0.2

comment:11 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Compared LoadEmptyInstrument with BASIS on 2.0.2 against 2.0.1: 1 sec vs 34 sec

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5662

Note: See TracTickets for help on using tickets.