Ticket #4816 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

AlgorithmDialog: Create reusable widgets for each property

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

GenericDialog and AlgorithmDialog are in dire need of refactoring. Start by creating independent widgets for each Property* type that can be REUSED in a encapsulated way, instead of the mess we have now.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #4816: Start of widgets for Property types

Changeset: 9e27ee45c4f7e57d4ed54996791532d8d0a9e95e

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4816 added TextPropertyWidget

Changeset: 45690cef7f934b70640ce236a34aa1795a69a710

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #4816 validator star label

Changeset: 4376876589f5b6c5753d95433f92cb5c73235dc5

comment:5 Changed 9 years ago by Janik Zikovsky

Refs #4816: Start of widgets for Property types

Changeset: 9e27ee45c4f7e57d4ed54996791532d8d0a9e95e

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #4816 added TextPropertyWidget

Changeset: 45690cef7f934b70640ce236a34aa1795a69a710

comment:7 Changed 9 years ago by Janik Zikovsky

Refs #4816 validator star label

Changeset: 4376876589f5b6c5753d95433f92cb5c73235dc5

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #4816 File, Options widgets; Factory.

Changeset: 411d7d21dfa03fbef4af785cb3de1c6df4ec5553

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4816 cleaning up Algorithm code

Changeset: 200eb69207db3d919a79b2eacfb506bdcc550833

comment:10 Changed 9 years ago by Janik Zikovsky

Refs #4816 more cleanup of GenericDialog

Changeset: d7377aab136f1bd1efc33f9e1fbd740e67aad033

comment:11 Changed 9 years ago by Janik Zikovsky

Refs #4816 dynamic enabling/hiding/new widgets

Changeset: ca35c09d64add73abb099d5bbe6d1908e8e6f56c

comment:12 Changed 9 years ago by Janik Zikovsky

Refs #4816: validator stars are working,

however at this stage the widgets are NOT hidden when first opening a dialog.

Changeset: 0b4f2bc6a6a995a65895745408ecef45e6f3c0fb

Last edited 9 years ago by Janik Zikovsky (previous) (diff)

comment:13 Changed 9 years ago by Janik Zikovsky

Refs #4816: replace output workspace name button works again

However it isn't hidden correctly for algos with no input workspace props, not sure why

Changeset: 14c4df489d4410d0bc723b4aaa344141e7ddbfd3

comment:14 Changed 9 years ago by Janik Zikovsky

Refs #4816 set parent of widgets

Changeset: b9a46c95e8ff47d833d95b1240e06ab14a20b98f

comment:15 Changed 9 years ago by Janik Zikovsky

Refs #4816 PropertyWidgets are correctly hidden

and the ReplaceWS button only shows up when needed

Changeset: f36d6fa09c53a0a11e88e5819da0448b98a5d9d3

comment:16 Changed 9 years ago by Janik Zikovsky

Refs #4816: remove illegal insertChild() call

Changeset: 95c8d6cc410e3fe6f08afe0eae7874c54dd43b80

comment:17 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: These are now used in the AlgorithmPropertiesWidget #4953.

See also ticket #4847 for possible moving of them to MantidWidgets.

Last edited 9 years ago by Janik Zikovsky (previous) (diff)

comment:18 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:19 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

Works as far as I can tell. Currently used in our auto-generated widgets.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5663

Note: See TracTickets for help on using tickets.