Ticket #4846 (assigned)
LoadSQW: transform the coordinates from Q to the scaled 'hkl'
| Reported by: | Janik Zikovsky | Owned by: | Andrei Savici |
|---|---|---|---|
| Priority: | minor | Milestone: | Backlog |
| Component: | Framework | Keywords: | |
| Cc: | alex.buts@… | Blocked By: | #4813 |
| Blocking: | Tester: |
Description (last modified by Janik Zikovsky) (diff)
Alex says: "When Andrei finishes his thicket on transformation matrix (#4813), changes and coordinate system scaling should be added to LoadSQW algorithm. "
Basically scale the axes so that a peak at H=1 is at a position of (1,0,0) on the axes. Changes the UNITS of the axes to something like 2.18 Ang-1.
Change History
comment:2 Changed 9 years ago by Alex Buts
User who loads sqw would expect to see the same image as he was observing when using Horace.
Horace currently writes momentum and energies in crystal frame, momentums in reverse A (see Units in Mantid), energies in mEv and also stores image, which is obtained from these (events) by an affine transformation. The transformation involves rotation and scaling to (almost) arbitrary units (scalable) The stored events are aligned with the image even if the image is not aligned with crystal orthogonal system (e.g. if the image's X-axis is along direction [1,1,0] and has limits -1,+1, these limits are applied to the projection of Q in crystal sytem on the axis [1,1,0]
The transformation is stored alongside with image. I am not sure, if it is direct or reverse transformation (QdE->image or image->QdE).
As Andrei works on creating and storing transformation, which would convert Q themselves into some non-axis aligned coordinate system, the idea of the ticket is to read Horace transformation and use it when reading events transforming them into the system where they belong.
When image is axis aligned, related to cubic lattice and in reverse lattice units, the transformation is reduced to the one, mentioned above.
comment:3 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:5 Changed 8 years ago by Janik Zikovsky
- Status changed from new to assigned
- Owner changed from Janik Zikovsky to Andrei Savici
Andrei, you can probably handle this request since you're more familiar with the whole axis units business...
comment:7 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to release 2.4
comment:8 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:12 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after the code freeze for R2.6
comment:13 Changed 7 years ago by Alex Buts
- Blocking 5226 removed
(In #5226) Load algorithm should be able to recognize sqw file (e.g. AutoTestData/test_horace_reader.sqw) , invoke LoadSQW interface and load sqw file properly.
Worth checking if it properly recognizes .SQW extension on Unix (it is somewhere in file helper and related to it so a person well familiar with this helper can give answer directly)
comment:14 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
bulk move to assigned at the into of the triage step
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5693
