Ticket #4859 (closed: fixed)
Improve file finding when using wildcards
| Reported by: | Peter Parker | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
Martyn has suggested we take a look at the findRun(s) functions of FileFinder and related code to see if any improvements can be made regarding wild cards in the extensions that are passed to it, specifically:
- The cases where a Mantid user might be accessing a large networked directory.
- The case where a class user wants more than one file returned, for example they might require "INST001.s01" and "INST001.s02" when they pass a hint of "INT001" and the extension ".s0*".
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:3 Changed 8 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Peter Parker
comment:4 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:5 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:7 Changed 8 years ago by Nick Draper
From Sarah Rogers:
Dear Nick,
Thanks for the update. With regards to the Mantid version I am running in my office it is 2.3.0. We certainly did put a ticket in for the gui to find .n* files sometime ago. I thought that the ticket had been addressed as the gui has worked fine for loading in these files for quite a while now but for some reason in the last two releases it seems to have stopped! Using the ‘open file’ method of reducing these files will be fine for now.
Thanks again and have a good Christmas.
comment:8 Changed 8 years ago by Peter Peterson
- Status changed from assigned to accepted
- Owner changed from Roman Tolchenov to Peter Peterson
comment:9 Changed 8 years ago by Peter Peterson
The underlying problem is wildcard extensions not getting matched properly. Try Load("LOQ16613.n001") to see the problem.
comment:10 Changed 8 years ago by Peter Peterson
Refs #4859. Add support for wildcards in extensions.
Moved getting the extension into a separate extension in FileFinder then strengthened the code and added more unit tests.
Changeset: ffcdead3271cf92712be3d086865d5e09dfdc2be
comment:11 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:12 Changed 8 years ago by Peter Peterson
Refs #4859. Add support for wildcards in extensions.
Moved getting the extension into a separate extension in FileFinder then strengthened the code and added more unit tests.
Changeset: 49d3cdc8605c3b97e966b5aa23038b2a2b1c40f1
comment:13 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:14 Changed 8 years ago by Michael Reuter
- Status changed from verifying to closed
Wildcards are now available in the facilities file.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5706
Refs #4859 - Remove wildcard extensions before finding runs.
This is the first step of this ticket, which removes the (currently buggy) findRun function in the case where there are two similar files with extensions of .s01 and .s02 and .s* has been passed as an extension to look for. In that case, only a single (arbitrarily picked) file is returned.
More work will be needed to accomodate extensions with wild cards properly.