Ticket #4879 (closed: fixed)
Curve Fitting to handle periodic parameters appropriately
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | roman.tolchenov@…, anders.markvardsen@… | Blocked By: | |
| Blocking: | Tester: | Jose Borreguero |
Description
The unit test of GausOsc gets a phase angle of about 765 degrees rather than the equivalent 45 degrees required.
I would be better if any periodic parameter (such as angle) is returned in an appropriate range of values, such as range 0 to 360 degrees or the equivalent in Radians for an angle.
I don't think the use of constraints is appropriate in such a case.
Change History
comment:2 Changed 9 years ago by Karl Palmen
- Owner set to Karl Palmen
- Status changed from new to accepted
comment:3 Changed 9 years ago by Karl Palmen
Use SetActiveParameter to put Phi in range re #4879
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 9bcd78b96035a069fc4eeb4ab488d0de1a0e0c78
comment:4 Changed 9 years ago by Karl Palmen
Use SetActiveParameter on Phi of ExpDecayOsc re #4879
Also use M_PI of <cmath> rather than a locally defined constant.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 910f7d55241b3b85a11bd80de62d95b56baec8fe
comment:5 Changed 9 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
No other fit function need this.
comment:6 Changed 9 years ago by Karl Palmen
Use SetActiveParameter to put Phi in range re #4879
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 9bcd78b96035a069fc4eeb4ab488d0de1a0e0c78
comment:7 Changed 9 years ago by Karl Palmen
Use SetActiveParameter on Phi of ExpDecayOsc re #4879
Also use M_PI of <cmath> rather than a locally defined constant.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 910f7d55241b3b85a11bd80de62d95b56baec8fe
comment:8 Changed 8 years ago by Jose Borreguero
- Status changed from verify to verifying
- Tester set to Jose Borreguero
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5726
The fix of #4858 changed the phase angle from 765 degrees to 405 degrees still equivalent to 45 degrees, requiring modifacation of the unit test.