Ticket #4882 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Modify Inelastic python code to make use of LoadMask

Reported by: Stuart Campbell Owned by: Martyn Gigg
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

An algorithm has been written to load masks. Currently in the CommonFunctions.py there is a function called load_mask() that parses a file itself. This should be modified to make use of the new algorithm.

Change History

comment:1 Changed 9 years ago by Stuart Campbell

The ticket that relates to this functionality being added to LoadMask is #4832.

comment:2 Changed 9 years ago by Stuart Campbell

  • Status changed from new to assigned
  • Owner set to Martyn Gigg

Assigning this to you Martyn as you seem to have written this mask parsing.

comment:3 Changed 9 years ago by Martyn Gigg

No problem, all things being equal I hope I can just drop it in.

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:5 Changed 8 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:6 Changed 8 years ago by Martyn Gigg

Replace python function with LoadMask. Refs #4882

Changeset: 3e69fca5dd2e41c96a629ea36beb95e4e0ab3446

comment:7 Changed 8 years ago by Martyn Gigg

Update inelastic test to use hard mask. Refs #4882

Changeset: b7eec33b1e4d4d0b8756e07b090d3af1992b13fd

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 8 years ago by Martyn Gigg

Add the hard mask file test data. Refs #4882

Changeset: db084462859c25a3ee19856001b0559ee2dc3d9f

comment:10 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This looks to be working just fine.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5729

Note: See TracTickets for help on using tickets.