Ticket #4898 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

WorkspaceProperty: add a flag to say NOT to lock the workspace

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: minor Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #4803 Tester: Stuart Campbell

Description

In the case of MonitorLiveData, I need the algorithm to NOT write-lock the OutputWorkspace when starting because the sub-algorithms will want to lock it too.

Also, any GUI getting a read-lock would hang until monitoring is over = never!

So, add a flag to WorkspaceProperty that will NOT lock the workspace.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #4898: WorkspaceProperty flag for no locking

And use it in Algorithm, and test

Changeset: 70066b3088aa069c9191426a34f6244750cf5562

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4898 adding a WriteLock object for scoped write locks

Changeset: c9462c9cd894365f67cea25f3563df5b74e4a217

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #4898 update test

Changeset: f355864cf5a9967b1f2505ae01e5ee6572e07cd0

comment:5 Changed 9 years ago by Janik Zikovsky

Refs #4898 update test

Changeset: 261bca755ceea294d5c80fe3b90ce8f3de38babd

comment:6 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: this is used in MonitorLiveData, but perhaps a code review is best?

comment:7 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:8 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Code looks ok - but I probably don't know as much about it as Janik anyway! :-)

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5744

Note: See TracTickets for help on using tickets.