Ticket #4911 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Mantid crashes if LoadMask() loads an incorrect instrument

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

If a component name is specified in XML file, while it is not a component of the given instrument, Mantid crashes.

For example, if the XML says that bank 123 and 124 to be masked for Vulcan, Mantid crashes.

Change History

comment:1 Changed 9 years ago by Wenduo Zhou

  • Status changed from new to accepted
  • type changed from enhancement to defect

comment:2 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:3 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:4 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:5 Changed 8 years ago by Peter Peterson

  • Milestone changed from Release 2.1 to Release 2.2

comment:6 Changed 8 years ago by Wenduo Zhou

Refs #4911. Fixes crash if a non-existing component is in XML file.

Changeset: ddc9afc1b52651dd499f1abb3a77d7a2498344bd

comment:7 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:9 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

The changed code looks like it fixes the issue.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5757

Note: See TracTickets for help on using tickets.