Ticket #4917 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Python algorithms cannot be cancelled during child algorithms. Also limit logging.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

If you launch a child algorithm in the usual AlgorithmName("bla") syntax, then it is not properly created as a child and so cannot be cancelled in the usual way in MantidPlot GUI.

At the same time, I want to (on option) limit the logging of these child algorithms. I know Mathieu wants this logging, but I don't and so add an option.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #4917 you can now cancel children of python algorithms

Because the calls to AlgorithmName(etc) are being re-routed as a proper createSubAlgorithm() call. Also carry over the logging state of parent to child.

Changeset: 100f77f366e79730449956739764281469d35f11

comment:3 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Testers: Try to cancel a slow PythonAlgorithm.

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #4917 you can now cancel children of python algorithms

Because the calls to AlgorithmName(etc) are being re-routed as a proper createSubAlgorithm() call. Also carry over the logging state of parent to child.

Changeset: 100f77f366e79730449956739764281469d35f11

comment:5 Changed 8 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:6 Changed 8 years ago by Peter Parker

  • Status changed from verifying to closed

Successfully cancelled OSIRISDiffractionReduction, which had spawned Load, which had spawned LoadRaw. Output:

LoadRaw: Execution terminated by user.
Load: Execution terminated by user.
Error in execution of algorithm OSIRISDiffractionReduction:
Python error: Algorithm terminated
...

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5763

Note: See TracTickets for help on using tickets.