Ticket #4919 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

REFM: produce 2D reduction

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Change the reduction code to work in 2D (pixel vs Q) and take the reflectivity curve from the 2D instead of calculating it directly

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

Re #4919 Prototype code for 2D reduction

Changeset: 9b2f504353397e125747e36dc4dcbd6c3f8c15eb

comment:2 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix scattering angle calculation

Changeset: 04be0af1b05ff0f48e7b80d0da0f892dea80fef4

comment:3 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix moderator position

Changeset: a1bd33f1fbf2a6a7f99bdb308a60c23ad7684d90

comment:4 Changed 9 years ago by Mathieu Doucet

Re #4919 Hook up number of points per run

Changeset: 6d299bfc628bd24dc9583572ba84d082c597422a

comment:5 Changed 9 years ago by Russell Taylor

Fix build. Re #4919.

Changeset: 0a7a855c9e623bad09f251d57f29b938a952f1c4

comment:6 Changed 9 years ago by Mathieu Doucet

Re #4919 Add choice of output directory

Changeset: dcffc6ada4b620a97c5541d94d2acffb1874bf11

comment:7 Changed 9 years ago by Mathieu Doucet

Re #4919 Save 4 refl curves after stitching

Changeset: 47d94600e84795c66d8c51abf9ab59b2fc3f2fdc

comment:8 Changed 9 years ago by Mathieu Doucet

Re #4919 Add stitching parameters to UI

Changeset: f24ad4a880957650bc07d644617076a8102c000b

comment:9 Changed 9 years ago by Mathieu Doucet

Re #4919 Add automated scale to R=1

Changeset: 37d37ae1f14535414f3f6d5fffb0ca372cae95ae

comment:10 Changed 9 years ago by Mathieu Doucet

Re #4919 Make we don't have an empty string for the output dir

Changeset: 9ba98cc2f90198ae468ed7c28eee0a69aef09697

comment:11 Changed 9 years ago by Mathieu Doucet

Re #4919 fix running condition when removing runs from lists

Changeset: ffcb938069d6d10cff8bc1a51a46385d048ff33a

comment:12 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix automated reduction for REFM

Changeset: 705ef77119ab9a301b1552e78bdf44633742c426

comment:13 Changed 9 years ago by Mathieu Doucet

Re #4919 Improve REFM stability

Changeset: aa8e79b78e60f9ccb26c7f3b7faaefbd39133d40

comment:14 Changed 9 years ago by Mathieu Doucet

Re #4919 clean up UI for REFL

Changeset: 20c2506423704b847bd29aa49c52d8983ca44777

comment:15 Changed 9 years ago by Mathieu Doucet

Re #4919 remove unnecessary import

Changeset: 5761726044bd87554a9bf2fe7c783af1cf44f2b8

comment:16 Changed 9 years ago by Mathieu Doucet

Re #4919 fix problem with state loading

Changeset: f40bf5dce8055bd987dc71acbbe2b5b775ad6585

comment:17 Changed 9 years ago by Mathieu Doucet

Re #4919 Prototype code for 2D reduction

Changeset: 9b2f504353397e125747e36dc4dcbd6c3f8c15eb

comment:18 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix scattering angle calculation

Changeset: 04be0af1b05ff0f48e7b80d0da0f892dea80fef4

comment:19 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix moderator position

Changeset: a1bd33f1fbf2a6a7f99bdb308a60c23ad7684d90

comment:20 Changed 9 years ago by Mathieu Doucet

Re #4919 Hook up number of points per run

Changeset: 6d299bfc628bd24dc9583572ba84d082c597422a

comment:21 Changed 9 years ago by Russell Taylor

Fix build. Re #4919.

Changeset: 0a7a855c9e623bad09f251d57f29b938a952f1c4

comment:22 Changed 9 years ago by Mathieu Doucet

Re #4919 Add choice of output directory

Changeset: dcffc6ada4b620a97c5541d94d2acffb1874bf11

comment:23 Changed 9 years ago by Mathieu Doucet

Re #4919 Save 4 refl curves after stitching

Changeset: 47d94600e84795c66d8c51abf9ab59b2fc3f2fdc

comment:24 Changed 9 years ago by Mathieu Doucet

Re #4919 Add stitching parameters to UI

Changeset: f24ad4a880957650bc07d644617076a8102c000b

comment:25 Changed 9 years ago by Mathieu Doucet

Re #4919 Add automated scale to R=1

Changeset: 37d37ae1f14535414f3f6d5fffb0ca372cae95ae

comment:26 Changed 9 years ago by Mathieu Doucet

Re #4919 Make we don't have an empty string for the output dir

Changeset: 9ba98cc2f90198ae468ed7c28eee0a69aef09697

comment:27 Changed 9 years ago by Mathieu Doucet

Re #4919 fix running condition when removing runs from lists

Changeset: ffcb938069d6d10cff8bc1a51a46385d048ff33a

comment:28 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix automated reduction for REFM

Changeset: 705ef77119ab9a301b1552e78bdf44633742c426

comment:29 Changed 9 years ago by Mathieu Doucet

Re #4919 Clean up algorithm properties

Changeset: da533358f5d0f136806679f011671efeb958d92c

comment:30 Changed 9 years ago by Mathieu Doucet

Re #4919 adding system test

Changeset: beff2af87e1737ef849354149dbe422551cdb6a1

comment:31 Changed 9 years ago by Mathieu Doucet

Re #4919 fix stitching for distributions (as opposed to histos)

Changeset: 685a2b473319beaa5f9f27eecefeeb3a2e63e724

comment:32 Changed 9 years ago by Mathieu Doucet

Re #4919 use different label for REFL plots

Changeset: f37e5c15e84097e99be88d3679f2ac5cd8571d81

comment:33 Changed 9 years ago by Mathieu Doucet

Re #4919 fix problem with stitching tab

Changeset: 04eae15828a7e87a7b55cd89e8c79c9b4de9b6c6

comment:34 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix system test

Changeset: 9adf2644f2291c05ca871518afe58262607b6f06

comment:35 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix system test

Changeset: b47bb995eda5c816f78ea7b468460182677e094c

comment:36 Changed 9 years ago by Mathieu Doucet

Re #4919 Add test algorithm to compare REFL and REFM

Changeset: 27252630e993a8e8831da0611fac65a2e2f61d54

comment:37 Changed 9 years ago by Mathieu Doucet

Re #4919 fix run lookup in REFM UI

Changeset: cd506b0dec8d7ae244ae9582c398f7d0d5698d90

comment:38 Changed 9 years ago by Mathieu Doucet

Re #4919 trying to fix ui layout for mac...

Changeset: 4630c216652448fe36e72fd541bdb28bf0661868

comment:39 Changed 9 years ago by Martyn Gigg

Backport REF_M definition

Re #4919 Fix moderator position

Re #4792 REF_M instrument definition and new algo (cherry-picked from ae352d724c8b74a80ec32f7b8c4ac07eab70c059 and a1bd33f1fbf2a6a7f99bdb308a60c23ad7684d90)

Changeset: 4ec0427854c1ae94056451632378209119d47b01

comment:40 Changed 9 years ago by Mathieu Doucet

Re #4919 fix stitching for distributions (as opposed to histos)

Changeset: 685a2b473319beaa5f9f27eecefeeb3a2e63e724

comment:41 Changed 9 years ago by Mathieu Doucet

Re #4919 use different label for REFL plots

Changeset: f37e5c15e84097e99be88d3679f2ac5cd8571d81

comment:42 Changed 9 years ago by Mathieu Doucet

Re #4919 fix problem with stitching tab

Changeset: 04eae15828a7e87a7b55cd89e8c79c9b4de9b6c6

comment:43 Changed 9 years ago by Mathieu Doucet

Re #4919 Add test algorithm to compare REFL and REFM

Changeset: 27252630e993a8e8831da0611fac65a2e2f61d54

comment:44 Changed 9 years ago by Mathieu Doucet

Re #4919 fix run lookup in REFM UI

Changeset: cd506b0dec8d7ae244ae9582c398f7d0d5698d90

comment:45 Changed 9 years ago by Mathieu Doucet

Re #4919 trying to fix ui layout for mac...

Changeset: 4630c216652448fe36e72fd541bdb28bf0661868

comment:46 Changed 9 years ago by Mathieu Doucet

Re #4919 Make refm reduction more robust

Changeset: e1da83c068127c16dcd24e844868d4dbdc6f4c24

comment:47 Changed 9 years ago by Mathieu Doucet

Re #4919 Make refm reduction more robust

Changeset: 32a2ff071e5b4cc0c54416aabb7895e49ce9400c

comment:48 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix problem with stitching UI

Changeset: 18095a6761e314fbd21550fff6a750094b89ad7e

comment:49 Changed 9 years ago by Mathieu Doucet

Re #4919 Change system test for new ref reduction implementation

Changeset: 49b2cbf7ae5f6b9823c19a40971dfb4cd73e043b

comment:50 Changed 9 years ago by Mathieu Doucet

Re #4919 remove old version of REFM reduction

Changeset: 9ca7549d963c1eb77825a070e11b0979c5fb23f2

comment:51 Changed 9 years ago by Mathieu Doucet

Re #4919 remove old version of REFM reduction

Changeset: 1aa5dc1727028bc7e2adc352f3ee363a34a0cccf

comment:52 Changed 9 years ago by Mathieu Doucet

Re #4919 Improve handling of lag time while using FileFinder

Changeset: 03f2634f3df2b82f100aab66c4a94cf93ac6639d

comment:53 Changed 9 years ago by Mathieu Doucet

Re #4919 fix output save

Changeset: 69344b3d23a1cac43eedf42c410e033d1ba9c255

comment:54 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix grouping in Y for reflectometers

Changeset: d19b2e8d3b1b64ad849fa62504e982774709824a

comment:55 Changed 9 years ago by Mathieu Doucet

Re #4919 Fix angle calculation

Changeset: 751df632acc1ed83a3a11952f25b651d0c51ce3e

comment:56 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:57 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:58 Changed 8 years ago by Mathieu Doucet

  • Status changed from new to accepted

This ticket is not very specific and risks getting out of hand. Since we are producing the 2D output and since the output has been confirmed correct with the instrument scientists, I'm going to call this done.

comment:59 Changed 8 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:60 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:61 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

This has been in production for a long time, so has effectively been tested by the users (see comment:58). Jean says it's good.

comment:62 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5765

Note: See TracTickets for help on using tickets.