Ticket #4924 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Removing the "Reducer" import from OSIRISDiffRed breaks VanillaPythonTest

Reported by: Peter Parker Owned by: Martyn Gigg
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

​Changes made to #4820 highlighted the fact that, for some unknown reason, removing the import of the "reducer" module in OSIRISDiffractionReduction breaks the VanillaPythonTest.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

Do not add package directories python sys.path. Refs #4924

Packages need to remain only accessible via the package-name.submodule else it breaks the whole point of them.

Changeset: f0435159db9dd9c22daae0032d033338a8aafab2

comment:3 Changed 8 years ago by Martyn Gigg

Fix the PythonObjectInstantiator test. Refs #4924

Changeset: ddaf3f6e81674ec946617c1b6839faabb42d74a9

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Martyn Gigg

Do not add package directories python sys.path. Refs #4924

Packages need to remain only accessible via the package-name.submodule else it breaks the whole point of them.

Changeset: f0435159db9dd9c22daae0032d033338a8aafab2

comment:6 Changed 8 years ago by Martyn Gigg

Fix the PythonObjectInstantiator test. Refs #4924

Changeset: ddaf3f6e81674ec946617c1b6839faabb42d74a9

comment:7 Changed 8 years ago by Martyn Gigg

Fix package imports to fix system tests. Refs #4924

Changeset: 94150df0389210b2f418ffb8667464260ad6a537

comment:8 Changed 8 years ago by Martyn Gigg

Fix package imports to fix system tests. Refs #4924

Changeset: 94150df0389210b2f418ffb8667464260ad6a537

comment:9 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:10 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Assuming that because OSIRISDiffractionReduction seems to work and VanillaPythonTest isn't broken, then this is ok! :-)

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5770

Note: See TracTickets for help on using tickets.