Ticket #493 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

ShapeFactory Improvements

Reported by: Nick Draper Owned by: Anders Markvardsen
Priority: critical Milestone: Iteration 16
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

  1. Move the ShapeFactory class to Geometery
  2. The class crashes the entire app if an incorrect string is entered into the algebra
  3. The class should be able to generate a default algebra sting if non is provided (assume you should union all inputted shapes).
  4. The class should recognise is an unknown shape definition is used and log that error.

Change History

comment:1 Changed 12 years ago by Anders Markvardsen

(In [2220]) Introduced extra checking of input XML string when using ShapeFactory; write out warning to user and return empty shape if there is a problem. Refs #493.

comment:2 Changed 12 years ago by Anders Markvardsen

(In [2248]) Introduced the idea of a default algebra string when defining a shape. Default is intersection. Wiki page also updated accordingly. Refs #493.

comment:3 Changed 12 years ago by Anders Markvardsen

(In [2255]) Roman moved ShapeFactory from DataHandling to Geometry. Refs #493.

comment:4 Changed 12 years ago by Anders Markvardsen

(In [2256]) Move ShapeFactoryTest to Geometry. Refs #493.

comment:5 Changed 12 years ago by Anders Markvardsen

(In [2263]) Allow in addition shapes to be generated from the ShapeFactory using a XML string input (mainly taken code from FindDetectorsInShape to do this). Refs #493.

comment:6 Changed 12 years ago by Anders Markvardsen

(In [2264]) Make FindDetectorsInShape call ShapeFactory using XML string interface. Refs #493.

comment:7 Changed 12 years ago by Anders Markvardsen

  • Status changed from new to closed
  • Resolution set to fixed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1341

Note: See TracTickets for help on using tickets.