Ticket #4936 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Fix Incorrect Export of C++ Function to Python

Reported by: Peter Parker Owned by: Martyn Gigg
Priority: major Milestone: Release 2.0.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

The IDetector function "getTwoTheta" is exported as .def("getTwotheta"), rather than .def("getTwoTheta").

Change History

comment:1 Changed 9 years ago by Peter Parker

  • Summary changed from Fix Incorrect Export of C++ to Python to Fix Incorrect Export of C++ Function to Python

comment:2 Changed 9 years ago by Peter Parker

  • Owner changed from Peter Parker to Martyn Gigg
  • Status changed from new to assigned

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Martyn Gigg

Refs #4936. Fix case of getTwotheta.

getTwotheta now raises a deprecated msg. It will be removed in a future release.

Changeset: adb395fda5b0f2ab6b3caa7fe980a899ae86ecc1

comment:5 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

See #4937.

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:7 Changed 9 years ago by Martyn Gigg

It looks like getDetectorIDs on DetectorGroup also has the same issue. This may as well be fixed here too.

comment:8 Changed 9 years ago by Martyn Gigg

Fix another case-issue in an export

Changeset: 94c9e68794c6cd876ac4808f5ae474af15bfb4cd

comment:9 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:10 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 9 years ago by Martyn Gigg

Fix case issues in Python interface

Refs #4936. Fix case of getTwotheta.

getTwotheta now raises a deprecated msg. It will be removed in a future release.

Refs #4936 Fix another case-issue in an export.

These commits were cherry-picked from adb395fda5b0f2ab6b3caa7fe980a899ae86ecc1 and 94c9e68794c6cd876ac4808f5ae474af15bfb4cd

Changeset: a55b014b791ebcde623476a44fab5c714286b5aa

comment:12 Changed 9 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.0.2

comment:13 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:14 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The two functions give the same answer but getTwotheta doesn't show the deprecation warning on Windows 7.

comment:15 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:16 Changed 9 years ago by Martyn Gigg

Refs #4936. Ensure deprecation messages are visible in release.

Changeset: b0fcc00aee69d244d764b54afe5ea31862e2f085

comment:17 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:18 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying

comment:19 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to closed

getTwotheta gives a deprecation message on its first call.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5782

Note: See TracTickets for help on using tickets.