Ticket #4937 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Remove deprecated getTwotheta member on IDetector in Python

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.1
Component: Python Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The member has been deprecated for a release so remove it.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:3 Changed 8 years ago by Martyn Gigg

  • Milestone changed from Release 2.4 to Release 2.5

comment:4 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:5 Changed 7 years ago by Martyn Gigg

  • Milestone changed from Release 2.6 to Release 2.7

Batch move to 2.7

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.7 to Backlog

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Martyn Gigg

  • Keywords Maintenance added
  • Component changed from Framework to Python API
  • Milestone changed from Backlog to Release 3.1

comment:9 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Remove deprecated IDetector python method.

Refs #4937

Changeset: a07b99cc13ca7a25795c6e5f6f8054fe38f2753c

comment:10 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: feature/4937_remove_deprecated_getTwotheta

Tester: The IDetector class in python had a method called getTwotheta that was exported, accidentally, with the incorrect case for the final theta. It had been deprecated and is now removed. Check that a script involving ws.getDetector(0).getTwoTheta() returns the expected result and that ws.getDetector(0).getTwotheta() no longer works.

Any matrixworkspace can be used for this so loading any datafile will be fine.

comment:11 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:12 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/4937_remove_deprecated_getTwotheta'

Full changeset: bb769230e8940bb8eb28561fa640487b839b077c

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5783

Note: See TracTickets for help on using tickets.