Ticket #4941 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make Qt DesignerPlugins simpler by reusing code

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: minor Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

  • There is a lot of repeated code in MantidQt/DesignerPlugins
  • Make it simpler.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #4941: macro to create a QtDesigner plugin very quickly

Changeset: 6288a56e29c6753b755b0d23c9baeccc4ec3ab75

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4941: now only 3 lines for a designer plugin

instead of 2 files and a couple hundred lines Removed the exisiting plugin files and replaced them with the use of that macro.

Changeset: d7f140e9396d2b6cadde32f7b4582c2ebe327636

comment:4 Changed 9 years ago by Janik Zikovsky

  • Summary changed from Make Qt DesignerPlugins more reused to Make Qt DesignerPlugins simpler by reusing code

Refs #4941 simplify designer plugins by using a base class

So I don't need 2 files per widget, just a few lines of code

Changeset: 61a84137e44415901e59306b22f8e5cfe2324934

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Testers: try out some of the plugins in qt-designer. You'll need to copy them to the right folder: 

sudo cp bin/designer/*.so /usr/lib/qt4/plugins/designer

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #4941 just comments

Changeset: ac49bd14f6c150d6004340f0182c04eaaa53a1d3

comment:7 Changed 9 years ago by Janik Zikovsky

Refs #4941: macro to create a QtDesigner plugin very quickly

Changeset: 6288a56e29c6753b755b0d23c9baeccc4ec3ab75

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #4941: now only 3 lines for a designer plugin

instead of 2 files and a couple hundred lines Removed the exisiting plugin files and replaced them with the use of that macro.

Changeset: d7f140e9396d2b6cadde32f7b4582c2ebe327636

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4941 just comments

Changeset: ac49bd14f6c150d6004340f0182c04eaaa53a1d3

comment:10 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This was done just fine. Looks much cleaner.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5787

Note: See TracTickets for help on using tickets.