Ticket #4946 (closed: fixed)
Vates Input Validation
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
- Ewings has asked that we make the inputs more robust on the PV plugins. He's rightly tried to enter stupid values into some of the entry fields and managed to bring the application down!
We should provide better input checking where we can. For example the number of bins will always be an integer > 0.
Make changes in the following locations.
- BinInputWidget types
- DimensionWidget
- ThresholdRangeWidget
All other autogenerate widgets, checking can be performed in the setters for such filters/sources.
Change History
comment:2 Changed 9 years ago by Owen Arnold
refs #4946 #4932. Implement LowHighStep.
Add validators to BinInputWidget type widgets.
Changeset: f3a185ffaa1349ceb41986586d665d78cafbae11
comment:3 Changed 9 years ago by Owen Arnold
refs #4946 input validation for ThresholdRangeWidget
Changeset: 541302bf94708660ee183b3bced9447d534624ce
comment:4 Changed 9 years ago by Owen Arnold
refs #4946 input validation for DimensionWidget min max
Changeset: ee477d6d3bbaf01bb9b3198e4724910b27785ece
comment:5 Changed 9 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester: Using the Rebinning filters, should not be able to enter non numeric values in numeric text boxes. Also, should find that for integer inputs, it's not possible to provide values to right of the decimal point.
comment:6 Changed 9 years ago by Owen Arnold
refs #4946 #4932. Implement LowHighStep.
Add validators to BinInputWidget type widgets.
Changeset: f3a185ffaa1349ceb41986586d665d78cafbae11
comment:7 Changed 9 years ago by Owen Arnold
refs #4946 input validation for ThresholdRangeWidget
Changeset: 541302bf94708660ee183b3bced9447d534624ce
comment:8 Changed 9 years ago by Owen Arnold
refs #4946 input validation for DimensionWidget min max
Changeset: ee477d6d3bbaf01bb9b3198e4724910b27785ece
comment:9 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:10 Changed 8 years ago by Michael Reuter
- Status changed from verifying to closed
The fixes seem to be working correctly.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5792
