Ticket #4954 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SCD Calibration of Rectangular Detectors

Reported by: Janik Zikovsky Owned by: Ruth Mikkelson
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description


Change History

comment:1 Changed 9 years ago by Janik Zikovsky

Refs #4954 fix scaled RectangularDetectors when accessing

via WS->getDetector()

Changeset: 3f6c41e486a25cad1031d5c1d1216157eded31e5

comment:2 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Initial checkin for Calibrating SCD detectors

Changeset: 8d497ba8b9d20e8b61830235e2c445fe45104378

comment:3 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Initial checkin for SCD Calibration code

Merge branch 'master' into Work1

Conflicts:

Code/Mantid/Framework/CurveFitting/CMakeLists.txt

Changeset: f5df8d682b02483011c29edb8f18fd19b1ba5fac

comment:4 Changed 9 years ago by Ruth Mikkelson

Refs #4954 fixed windows compiler error

Changeset: 234bd0685ab13ef96da511a4039d982c99bfbf03

comment:5 Changed 9 years ago by Russell Taylor

Re #4954. Fix Windows build: use vector instead of array.

In C++, vectors are (usually) good; C arrays no so good.

Changeset: b62c080b609cce8bce78dfe8a90bf811ba9bf64d

comment:6 Changed 9 years ago by Russell Taylor

Re #4954. Really fix Windows build.

And clean up a bit to avoid compiler warnings.

Changeset: 96ccfba1cd3698dc3ffb94b90223db9404975df6

comment:7 Changed 9 years ago by Ruth Mikkelson

  • Status changed from new to accepted

comment:8 Changed 9 years ago by Ruth Mikkelson

Refs #4954. Calibration Algorithm now functions in several states

Changeset: b30ca037489581df613dbf40a4dafc1d28ad1117

comment:9 Changed 9 years ago by Ruth Mikkelson

Refs #4954. Added Calibration algorithm to build.

Changeset: 62d9964928cd35cf227d0250a64a896dcb7a8aa8

comment:10 Changed 9 years ago by Ruth Mikkelson

Refs #4954. Fixed a compiler error in snowleopard

Changeset: 890bbc9d92bbabde8d0c79337b1fda2a5a4e75ea

comment:11 Changed 9 years ago by Russell Taylor

Re #4954. Initialize variable to zero to quash compiler warning.

But why is it not set properly anywhere?

Changeset: e10e02fc39f21e66195ec656a1f5da6bc60587e9

comment:12 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Incremental Improvements for Calibration

  1. Added more const's to SCDPanel Errors
  2. Found and eliminated slow down. Added deriv check to test program
  3. Increased number of iterations in SCDCalibratePanels( due to 2). Fixed an error in the xml output Changeset: 88b565e31b369a30b163a08e624da953f0bf1ded

comment:13 Changed 9 years ago by Ruth Mikkelson

Refs #4954. Checked derivative values

Changeset: 4678f63b8fc39480c8790d6edf6bbdc2048c42e9

comment:14 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Save to Check original code

Changeset: f6ba89ceb52b88f3e158c9e26f8cb15ad5962b66

comment:15 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Added most to all additional features

  1. Handles nonsense parameters( detWidth negative)
  2. Grouping of detector panels now supported
  3. A Calibration test program has been added
  4. Application of previous calibration file now supported
  5. Table workspaces for Parameter Results( and errors), Q errors, and

the Coveriance matrix are now reported.

Changeset: 1779bfdc93e186324af5270531946a2e84302d14

comment:16 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Added one change

Changeset: 3d7d21d370e8f45c75b303c86ec2ba99345e78d1

comment:17 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Added SCDCalibratpe Panel Test program

Changeset: 92b6c25e364c9c08d4d59f66a6c75faad853b613

comment:18 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Fix of windows error I hope

Changeset: 1eff25653a63027bdff396d50e3f7651483c96c2

comment:19 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Git rid of more compiler errors on other systems

Changeset: fa04035119b0d559e03929619b8eecb74a40683b

comment:20 Changed 9 years ago by Ruth Mikkelson

Refs #4954 Eliminated SCDCalibration test for snowleopard

Changeset: 07060f363f4870fc0d77a697c183c410cdbdaa07

comment:21 Changed 8 years ago by Vickie Lynch

Refs #4954 SNAP parameter map bug fixed

Changeset: 954dff03a4e3abeee677dc12973f734476f66378

comment:22 Changed 8 years ago by Vickie Lynch

Refs #4954 SNAP parameter map bug fixed

Changeset: 954dff03a4e3abeee677dc12973f734476f66378

comment:23 Changed 8 years ago by Ruth Mikkelson

Refs #4954 Reset the Enabling of properties

Changeset: 32b9ffd238a1e8dbe51f679c7f259e6c598eec7e

comment:24 Changed 8 years ago by Ruth Mikkelson

Refs #4954 Reset the Enabling of properties

Changeset: 32b9ffd238a1e8dbe51f679c7f259e6c598eec7e

comment:25 Changed 8 years ago by Ruth Mikkelson

Refs #4954 Elim cppChecks, oxygen checks, start dup code

Reusabel code segments moved to static methods that are more amenable for reuse

Changeset: 38496fae06a9b54074c690adb20fc946f2d9bd72

comment:26 Changed 8 years ago by Ruth Mikkelson

Refs #4954 Elim compiler error on snowLeopard

Changeset: 378489f752aba29e26c48ec70043ad0deecfc970

comment:27 Changed 8 years ago by Ruth Mikkelson

Refs #4954 Elim cpp and doxygen warnings.

Also added tof,dspace,run number, etc. columns to the information output tables

Changeset: 6b839bea1356276a489fa5ca7623c9b2db0f3a9a

comment:28 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:29 Changed 8 years ago by Russell Taylor

  • Milestone set to Release 2.2

comment:30 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:31 Changed 8 years ago by Vickie Lynch

Refs #4954 PreProcFileName not required for No Preprocessing option

Changeset: 36c0c068fd92863c5f722cd2126451af0c65c0a0

comment:32 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to closed

Calibration works well for TOPAZ_3131

comment:33 Changed 8 years ago by Vickie Lynch

Refs #4954 PreProcFileName not required for No Preprocessing option

Changeset: 36c0c068fd92863c5f722cd2126451af0c65c0a0

comment:34 Changed 8 years ago by Vickie Lynch

Refs #4954 PreProcFileName not required for No Preprocessing option

Changeset: 36c0c068fd92863c5f722cd2126451af0c65c0a0

comment:35 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5800

Note: See TracTickets for help on using tickets.