Ticket #4970 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Algorithm: add a mechanism for "holistic" validation of properties

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description (last modified by Janik Zikovsky) (diff)

  • After setting all the properties, but just before executing an algorithm, do a "finalValidation()" checking all the properties.
  • This check can look at several properties that depend on each other, instead of just validating a single one.
  • This returns a map where:
    • Key = string name of the the property
    • Value = string describing the problem with the property.

Will use in StartLiveData dialog.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted
  • Description modified (diff)

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #4970 mechanism to validate all inputs before execution,

API side and also refs #4787 added to LoadLiveData

Changeset: 36f56a6dd9560862c908d9e75d54c54165c3380c

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4970 validateInputs() creates stars for custom dialogs,

but not for genericDialog yet

Changeset: 6b7598f21e5a19771edebdd5f8463f65498500ff

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #4970 whole-algorithm validation works with GenericDialog

also remove couple of warnings I added

Changeset: 50ef1c25034baa0dd8c50913ccb91b332030f49b

comment:5 Changed 9 years ago by Janik Zikovsky

Refs #4970 make the algorithm fail when executing

if validateInputs() returns something

Changeset: 97a0ae51d06c6c5e04161090a49e3522a5e36c5e

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #4970 fix bad include

Changeset: c386e400ba0bedba53d72bf77408a8f3bf1c59e5

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #4970 mechanism to validate all inputs before execution,

API side and also refs #4787 added to LoadLiveData

Changeset: 36f56a6dd9560862c908d9e75d54c54165c3380c

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4970 validateInputs() creates stars for custom dialogs,

but not for genericDialog yet

Changeset: 6b7598f21e5a19771edebdd5f8463f65498500ff

comment:10 Changed 9 years ago by Janik Zikovsky

Refs #4970 whole-algorithm validation works with GenericDialog

also remove couple of warnings I added

Changeset: 50ef1c25034baa0dd8c50913ccb91b332030f49b

comment:11 Changed 9 years ago by Janik Zikovsky

Refs #4970 make the algorithm fail when executing

if validateInputs() returns something

Changeset: 97a0ae51d06c6c5e04161090a49e3522a5e36c5e

comment:12 Changed 9 years ago by Janik Zikovsky

Refs #4970 fix bad include

Changeset: c386e400ba0bedba53d72bf77408a8f3bf1c59e5

comment:13 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:14 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5816

Note: See TracTickets for help on using tickets.