Ticket #498 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Speed-up diffraction focusing

Reported by: Laurent Chapon Owned by: Laurent Chapon
Priority: major Milestone: Iteration 16
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Diffraction focusing is slow, and becomes a real problem for large instrument/slow machines. Should be able to take advantage of the focusing method to create only one vector temporary instead of chaining existing algorithms.

Change History

comment:1 Changed 12 years ago by Laurent Chapon

(In [2168]) re#498 Add clear calls for the ynew and Enew vectors of the rebin routine to make sure reference to prevous data is erased.

comment:2 Changed 12 years ago by Laurent Chapon

(In [2169]) re#498 First commit of this algorithm. It process each spectra at the time, which avoid large memory consumption when dealing with large datasets. Also it validates the consistency of the grouping in the file and the eventual Grouping of detectors in the workspace. The d-spacing range is now individual to each group and not common to the entire workspace. To do: validator for the Input workspace To do: propagate the geometry gouping. To do: find a way to weight the contribution of each spectra to each point in the range.

comment:3 Changed 12 years ago by Laurent Chapon

(In [2177]) re#498 Minor: Improve message when throw non valid bondaries

comment:4 Changed 12 years ago by Laurent Chapon

(In [2187]) re#498 Create a new function for rebinning. This is about 35% faster than old routine. Need to write unit for that. Speed-up diffraction focussing by a factor 2.5. It does take advantage of this new rebinning routine and also avoid copying each vector and only propagate errors at the end. On a 2GHz processor, running diffraction focussing on HRPD data now takes ~0.2 sec

comment:5 Changed 12 years ago by Laurent Chapon

(In [2189]) re#498 Add workspace Validator for RAW counts and X-unit as dSpacing

comment:6 Changed 12 years ago by Laurent Chapon

(In [2199]) re#498 Change to the new RebinHistogram. Should now be correct.

comment:7 Changed 12 years ago by Laurent Chapon

(In [2216]) re#498 Change rebinHistogram. Was a mistake in upper bound

comment:8 Changed 12 years ago by Laurent Chapon

(In [2217]) re#498 First part of the unit-test of new Rbin function

comment:9 Changed 11 years ago by Nick Draper

  • Status changed from new to closed
  • Resolution set to fixed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1346

Note: See TracTickets for help on using tickets.