Ticket #4984 (closed: fixed)
Make GetDetOffsetsMultiPeaks work for NOMAD
| Reported by: | Peter Peterson | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Vickie Lynch |
Description
The nominal d-value of the reference peaks is way off for low angle detectors. Make all of the finding code more rhobust to this error.
Change History
comment:1 Changed 9 years ago by Peter Peterson
- Owner set to Peter Peterson
- Status changed from new to accepted
comment:2 Changed 9 years ago by Peter Peterson
Refs #4984. Don't use the peak for offsets if it wasn't found.
Changeset: ba3b113eb945d76d0422331cafaa646498c96694
comment:3 Changed 9 years ago by Peter Peterson
Refs #4984 and #4985. Addig a column for chisq to the results.
Changeset: 3362809a8c7bcf728e239cc124cb59f209c9e074
comment:4 Changed 9 years ago by Peter Peterson
Refs #4984. Added options to specify background.
Changeset: efb8560b37b361a974492362c268de293763106a
comment:5 Changed 9 years ago by Peter Peterson
Refs #4984. Don't use the peak for offsets if it wasn't found.
Changeset: ba3b113eb945d76d0422331cafaa646498c96694
comment:6 Changed 9 years ago by Peter Peterson
Refs #4984 and #4985. Addig a column for chisq to the results.
Changeset: 3362809a8c7bcf728e239cc124cb59f209c9e074
comment:7 Changed 9 years ago by Peter Peterson
Refs #4984. Added options to specify background.
Changeset: efb8560b37b361a974492362c268de293763106a
comment:8 Changed 9 years ago by Peter Peterson
Refs #4984. Reworked GetDetOffsetsMultiPeaks for windows.
Not only have methodology for Generating fit windows for peaks, but also weight the fits for offsets by chisq for each peak. e.g. Bad fits count less.
Changeset: afbd23b4ab7b35caab5877094b01b1a4828af4d3
comment:9 Changed 9 years ago by Peter Peterson
Refs #4984. Changed log info for peak windows.
Changeset: e90ad00abe667f32fff6697dbcab11917ce8fe33
comment:10 Changed 9 years ago by Peter Peterson
Refs #4984. Added new options for GetDetOffsetMultiPeaks.
Changeset: e28978f0feb04d5adef4e4df7f911baf9c76451d
comment:11 Changed 9 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:12 Changed 9 years ago by Peter Peterson
- Status changed from verify to reopened
- Resolution fixed deleted
There needs to be an interpolation step when summing together pixels.
comment:14 Changed 9 years ago by Peter Peterson
Refs #4984. Added option for background subtraction.
Changeset: 46b95000685621e8afa612c1dc4818febb980e8e
comment:15 Changed 9 years ago by Peter Peterson
Refs #4984. Output an OffsetsWorkspace if that is the input.
Changeset: 12148660655d7b523f0d44adc0bbb330f993853d
comment:16 Changed 9 years ago by Peter Peterson
Refs #4984. Interpolate calibration if neighbors are summed.
Changeset: 999a63acef1808c32955206d76b4cd83b2d984e6
comment:17 Changed 8 years ago by Peter Peterson
Refs #4984. Moved to using MaskWorkspace in more places.
Changeset: 78659419161d931a1d92954e17c1312f57c75c12
comment:18 Changed 8 years ago by Peter Peterson
Refs #4984. Moved to using MaskWorkspace in more places.
Changeset: 78659419161d931a1d92954e17c1312f57c75c12
comment:19 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:20 Changed 8 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:21 Changed 8 years ago by Vickie Lynch
- Status changed from verifying to closed
Nomad calibrations are working. FindPeaks's changes on April 27 changed the offsets so I will add a ticket to change GetDetOffsetMultiPeaks to get better calibrations with the new FindPeaks.
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5830
