Ticket #4991 (closed: fixed)
Investigate slowdown in CreateWorkspace performance test
| Reported by: | Russell Taylor | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | martyn.gigg@… | Blocked By: | |
| Blocking: | Tester: | Owen Arnold |
Description (last modified by Russell Taylor) (diff)
The changes to the validators under #4949 have slowed down the performance test for the CreateWorkspace algorithm markedly. The SNS jobs have gone from 3->6s at commit [c20c02a8], whilst the ISIS job claims that the time taken went from 6 -> 20 minutes!
Attachments
Change History
comment:2 Changed 9 years ago by Martyn Gigg
20 minutes! Something sounds fishy there.
I'll have a look on Monday and see if I can find out what has caused the slowdown. There may be some additional copying going on that needs cutting out.
comment:3 Changed 9 years ago by Martyn Gigg
- Status changed from new to accepted
- Owner set to Martyn Gigg
comment:4 Changed 9 years ago by Martyn Gigg
Fix validators to pass by pointer to boost::any. Refs #4991
This avoids copying large containers around.
Changeset: d858c187c52d67f72f7cb85c93a072b837a2dd78
Changed 9 years ago by Russell Taylor
- Attachment AlgorithmsTest.CreateWorkspaceTestPerformance.testBigWorkspace.runtime.v.revision.png added
comment:5 Changed 9 years ago by Russell Taylor
The above picture shows that things are back to where they were with the original validators.
comment:6 Changed 9 years ago by Martyn Gigg
Fix validators to pass by pointer to boost::any. Refs #4991
This avoids copying large containers around.
Changeset: d858c187c52d67f72f7cb85c93a072b837a2dd78
comment:7 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:8 Changed 8 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:9 Changed 8 years ago by Owen Arnold
- Status changed from verifying to closed
Performance of CreateWorkspaceTestPerformance spiked and is now back to a normal.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5837
