Ticket #4995 (closed: worksforme)

Opened 9 years ago

Last modified 5 years ago

Tables need workspace name in window

Reported by: Peter Peterson Owned by: John Hill
Priority: minor Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description

Using "show data" on a table workspace will create a window with a title "Table-1" rather than the workspace's name. This is difficult to use when looking at multiple table workspaces since the name of the window depends on the order they are created.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:2 Changed 8 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

http://www.mantidproject.org/Release_Notes_2_2_Full_List

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:5 Changed 8 years ago by Karl Palmen

I tried it today and got "Table-1 -" followed by the name of the workspace in the title bar of the table display.

Should this "Table-1 -" remain or should only the workspace name be used or perhaps "Table -" followed by workspace name?

For a Matrix Workspace, the title bar of the show data table display has the name of the workspace followed by "- Mantid". I think we need some consistency here.

comment:6 Changed 8 years ago by Karl Palmen

  • Owner changed from Anyone to Karl Palmen

I'd change it to the name of workspace name followed by "- Mantid Table".

comment:7 Changed 8 years ago by Karl Palmen

Unable to find code that assembles the Show Data window title.

comment:8 Changed 8 years ago by Karl Palmen

  • Owner changed from Karl Palmen to Anyone

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:11 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:12 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:13 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:14 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:15 Changed 6 years ago by John Hill

  • Status changed from assigned to verify
  • Owner changed from Anyone to John Hill
  • Resolution set to worksforme

This seems to have been fixed; the table window title shows as the WS name.

comment:16 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:17 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed
  • Milestone changed from Backlog to Release 3.3

Worksformetoo! And it has been always working, that I remember.

This is done for example in ​https://github.com/mantidproject/mantid/blob/master/Code/Mantid/MantidPlot/src/Mantid/MantidMatrix.cpp#L80. The proper parameter (workspace name) is passed for example from MantidUI::importMatrixWorkspace in ​https://github.com/mantidproject/mantid/blob/master/Code/Mantid/MantidPlot/src/Mantid/MantidUI.cpp#L478

So everything seems fine.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5841

Note: See TracTickets for help on using tickets.