Ticket #4997 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

BinMD on MDHistoWorkspace: handle a "modified" MDHistoWS

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: pascal.manuel@… Blocked By:
Blocking: Tester: Michael Reuter

Description

If someone modifies a MDHistoWS, e.g. wk1 - wk2, and then calls BinMD (e.g. using the LineViewer), only the first workspace will be used!

I'm not sure how to handle the situation. Perhaps simply reject it for now (cut out the link between original and histo, or mark it as "modified")? Other algorithms, e.g. multiply, would modify the data so as to make the result incorrect.

Change History

comment:1 Changed 8 years ago by Janik Zikovsky

  • Status changed from new to accepted

One answer is to tell people to use SliceMD if they'll need to to + or - on their slices. That will work.

Cutting out the link between workspaces would remove the ability to view coordinates in the SliceViewer, so that is not the best solution.

Perhaps I will just add a flag in sample_logs.

comment:2 Changed 8 years ago by Janik Zikovsky

Refs #4997: don't allow binning a modified MDHistoWorkspace

If you modify a MDHisto with +, -, * etc. you cannot run BinMD afterwards because it would work quietly but give incorrect results.

Changeset: 9085fb4bc773d3f56422a41d03c37dbcff396040

comment:3 Changed 8 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: Call BinMD, then PlusMD, MultiplyMD etc. on the MDHistoWorkspace.

Further calls to binMD e.g. the line plot from the SliceViewer will throw an error.

Last edited 8 years ago by Janik Zikovsky (previous) (diff)

comment:4 Changed 8 years ago by Janik Zikovsky

Refs #4997: don't allow binning a modified MDHistoWorkspace

If you modify a MDHisto with +, -, * etc. you cannot run BinMD afterwards because it would work quietly but give incorrect results.

Changeset: 9085fb4bc773d3f56422a41d03c37dbcff396040

comment:5 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This works correctly.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5843

Note: See TracTickets for help on using tickets.