Ticket #5002 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LiveData GUI: use a separate AlgorithmInputHistory

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.1
Component: Mantid Keywords: LiveData
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

.. for storing the properties last entered by the user for Live Data processing algorithms; separate from regular processing.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

Refs #5002: StartLiveData GUI algos remember previous input

This is in a separate history from the other algorithms. Saved to QSettings so it persists

Changeset: 390d4024d79d9929302128c66b8e611658411f9c

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #5002: Algorithm->asString() method can use ; separator

because the comma is ambiguous

Changeset: 8269a08d0f0dc3d648d5de79e8912784228636a7

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #5002: last settings for algo/script pop up in custom GUI

Changeset: 7e9a1d14c4da1c732f5990a964fedb91591e6a23

comment:5 Changed 9 years ago by Janik Zikovsky

Refs #5002 fix bad include for windows

Changeset: ce89ddd6630371d2e4175f1b29a62270c3303e83

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #5002 fix LiveDataAlgorithmTest

Changeset: 55c5a6098f5c47f02dd375214a26edc880b2ff6f

comment:7 Changed 9 years ago by Janik Zikovsky

Refs #5002 fix python test

Changeset: 7d8ca6039d1186008791caa4fc04177929af134a

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: the parameters typed in the StartLiveData dialog for the pre- and post-processing step algorithms should be preserved when you switch algorithm; when you reopen the dialog; and when you re-start mantid. They should be different than the general memory for settings.

Would be good to test on non-unix platform.

comment:9 Changed 9 years ago by Russell Taylor

Re #5002. Keep AlgInputHistory variant a singleton for safety.

Changeset: fe28f1f0a5b1e9884e14ff9d0fa976ccdb3ef5c7

comment:10 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:11 Changed 8 years ago by Russell Taylor

  • Keywords LiveData added

comment:12 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

The 'live' version and regular algorithms do keep their last run saved values separately. I've tested a couple of different algorithms (Rebin and SumSpectra) on Linux, Mac and Windows... all seems fine.

I presume that it is the intended functionality to have a shared history between the pre- and post- processing algorithms ? (If not, just reopen this ticket)

comment:13 Changed 8 years ago by Janik Zikovsky

Russell and I had discussed it and it seemed reasonable to share the history, so this is intentional; it would be easy to NOT share it if someone requests it.

comment:14 Changed 8 years ago by Russell Taylor

And if someone did ask for it (now), it's definitely a task to go in a new ticket for the next release.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5848

Note: See TracTickets for help on using tickets.