Ticket #5008 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

[IDA] FuryFit - Fixes To Passed Fitting Function

Reported by: Peter Parker Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords: IDA
Cc: Blocked By:
Blocking: Tester: Arturs Bekasovs

Description (last modified by Samuel Jackson) (diff)

  • The fitting function passed thru for single exp is:
    name=LinearBackground,A0=0,A1=0,ties=(A1=0);
    name=UserFunction,Formula=Intensity*exp(-(x/Tau)),Intensity=0.976953,Tau=0.0289162;
    ties=(f1.Intensity=1-f0.A0)
    
    A single spectrum fit uses the fitted parameters for Intensity & Tau, bit not for A0 of Linear Background.
  • For stretched exp it is:
    name=LinearBackground,A0=0,A1=0,ties=(A1=0);
    name=UserFunction,Formula=Intensity*exp(-(x/Tau)^Beta),Intensity=0.981297,Tau=0.0250165,Beta=0.841352;
    ties=(f1.Intensity=1-f0.A0)
    

Again A0 not passed through.

  • There should also be a constraint on Beta so that 0 < Beta < 1.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:3 Changed 8 years ago by Peter Parker

  • Keywords IDA added

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:9 Changed 7 years ago by Samuel Jackson

  • Owner changed from Peter Parker to Samuel Jackson
  • Description modified (diff)

comment:10 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

comment:11 Changed 7 years ago by Samuel Jackson

Adding constraint to Beta parameter.

Refs #5008

Changeset: 5fa677e7ba28f87258837a75a936443bd2d3db19

comment:12 Changed 7 years ago by Samuel Jackson

Found better function for constaints.

Refs #5008

Changeset: e7acf689825ce6acc5482fe124fb30820303a463

comment:13 Changed 7 years ago by Samuel Jackson

Fixed A0 parameter not being passed correctly.

Refs #5008

Changeset: 74746ee22a55d0f5ce5ccd10c50df27a9c7315ec

comment:14 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test:

Run a FuryFit and make sure that the A0 parameter is set to something greater than 0. Check that this works with both a single and sequential fit and with a regular and stretched lorenzian.

Also check that a stretched lorenzian only takes beta value between 0 and 1.

comment:15 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.0

comment:16 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verify to verifying
  • Tester set to Arturs Bekasovs

comment:17 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/5008_furfit_param_passing'

comment:18 Changed 7 years ago by Arturs Bekasovs

Code changes are pretty straightforward and perfectly appropriate.

Testing a FuryFit on irs26176_graphite002_red.nxs showed that A0 is indeed set to the value greater than 0 using all the options of the dialog. In some cases, when starting parameters are not sensible, it can happen that A0 is less than 0 and fitted line is far from ideal, but repeating fit improves the situation.

During the testing Beta value was never out of the [0;1] interval.

comment:19 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Indirect Inelastic

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5854

Note: See TracTickets for help on using tickets.