Ticket #5030 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

StipVanadiumPeaks

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

It is broken for NOMAD in the middle of SNSPowderReduction for (5429-5426)/(5428-5426). It appears to be missing the very first d-spacing in the FindPeaks fit and failing as a result.

Change History

comment:1 Changed 9 years ago by Peter Peterson

Merge remote-tracking branch 'origin/master'. Refs #5030.

Conflicts:

Code/Mantid/Framework/Algorithms/src/FindPeaks.cpp

Changeset: 9e1ef8db3edb8cc6bffea8d8475ab6c6fdccc4ad

comment:2 Changed 8 years ago by Peter Peterson

Refs #5030. Return failed fit if can't get the background.

Changeset: ad5e7772538f31721d5ede1ad5127fd39d76025a

comment:3 Changed 8 years ago by Peter Peterson

Refs #5030. Select background type for StripVanadiumPeaks.

Changeset: 270bff8fdfefa882efb18e19bbd4a23ff535e41e

comment:4 Changed 8 years ago by Peter Peterson

Refs #5030. Fixing broken unit test.

Changeset: 8cf6e1fa1930d6a12beb1b2bac96531bf98e711f

comment:5 Changed 8 years ago by Peter Peterson

Refs #5030. Added a parameter for maximum chisq to use found peaks.

Changeset: c7fc686528c108ef19b3cbeac0fc399c8a5154ff

comment:6 Changed 8 years ago by Peter Peterson

Refs #5030. Added system test for strip peaks.

Changeset: 36ff57ac53fcde11626be88c41b83e6d62bc2762

comment:7 Changed 8 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson

comment:8 Changed 8 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:10 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5876

Note: See TracTickets for help on using tickets.