Ticket #5051 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Create a new subclass for full reduction type algorithms

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: doucetm@… Blocked By:
Blocking: #5157 Tester: Wenduo Zhou

Description

DataProcessorAlgorithm is meant to be a placeholder for all of the functions described ​here. The idea is that the new class will contain common functionality for working with lists of runs, chunking, etc.

Change History

comment:1 Changed 9 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson
  • Cc doucetm@… added

comment:2 Changed 9 years ago by Peter Peterson

Refs #5051. Repeating change to SNSPowderReduction2.

Changeset: a85909a5e41745ff91c7fc4e9bdc08fde5b5d791

comment:3 Changed 9 years ago by Peter Peterson

Refs #5051. First round of the new helper algorithm.

Almost every method just throws a runtime_error and has the wrong signature. At least there is a place to put all of the functionality though.

Changeset: feac0dd50f0e60f2e66158c298354848d59d5d5b

comment:4 Changed 8 years ago by Peter Peterson

Refs #5051. Fixing windoze build.

Changeset: 8455192874830529f4683656376721290a92410a

comment:5 Changed 8 years ago by Peter Peterson

Refs #5051. Fixing windoze build.

Changeset: 8455192874830529f4683656376721290a92410a

comment:6 Changed 8 years ago by Martyn Gigg

As an amendment I'm adding to this that we need this algorithm to set that history will be recorded for any of its child algorithms.

comment:7 Changed 8 years ago by Martyn Gigg

  • Blocking 5157 added

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:9 Changed 8 years ago by Mathieu Doucet

Re #5051 Starting to fill in DataProcessorAlgorithm

Changeset: 8531b25f8d7decf00fa6c74e8915380c385f451d

comment:10 Changed 8 years ago by Mathieu Doucet

Re #5051 Prototype processor algorithm

Changeset: 878fb0cfd30d08c1d412ad71452b0fa598145b60

comment:11 Changed 8 years ago by Mathieu Doucet

Re #5051 push the wrong file... fixing it now

Changeset: 443ee5aeea68a33b16d40a50e6a6aa5825c62b74

comment:12 Changed 8 years ago by Mathieu Doucet

Re #5051 removing unused file

Changeset: 0e5eab82cd81242efd952119df2f28aa31d517c6

comment:13 Changed 8 years ago by Russell Taylor

Re #5051. Fix MPI build.

Changeset: 61bc8a767140b139c92ddf528ee2bad8842e4f1c

comment:14 Changed 8 years ago by Mathieu Doucet

Re #5051 Added functionality to DataProcessorAlg

Changeset: 2fd6f57e553f781bb994d06baf28687a60768979

comment:15 Changed 8 years ago by mdoucet

Re #5051 exposed optional flag of workspace properties to python

Changeset: 18a7c77d67d419f9c07a2815ce8e0ac3c072db03

comment:16 Changed 8 years ago by Mathieu Doucet

Re #5051 Added EQSANS reduction example for mpi/live

Changeset: 4d8d370d455b553c44a0fabafafc73653a040d32

comment:17 Changed 8 years ago by Mathieu Doucet

Re #5051 Add system test for new data processor alg

Changeset: ecc006a7d946a4ee5eae77bea25d4f9a064836ad

comment:18 Changed 8 years ago by Mathieu Doucet

Re #5051 forgot a config file for system test

Changeset: 7ff3602734e1bc4932abb05bd4abda1d2d7ee3ef

comment:19 Changed 8 years ago by Mathieu Doucet

Re #5051 Adding documentation

Changeset: fa2e1d9e70ec5d4efd07ceb306fd34033f507fa8

comment:20 Changed 8 years ago by Mathieu Doucet

Re #5051 Fixing missing or inaccurate documentation

Changeset: 45b4c61f1e6a88accb12ca546a07bd1ec2cac6a9

comment:21 Changed 8 years ago by Mathieu Doucet

Re #5051 Modify ComputeSensitivity to use DataProcessorAlg

Changeset: b786e944ffc3305af732e6942d063784989f5974

comment:22 Changed 8 years ago by Mathieu Doucet

Re #5051 Starting to fill in DataProcessorAlgorithm

Changeset: 8531b25f8d7decf00fa6c74e8915380c385f451d

comment:23 Changed 8 years ago by Mathieu Doucet

Re #5051 Prototype processor algorithm

Changeset: 878fb0cfd30d08c1d412ad71452b0fa598145b60

comment:24 Changed 8 years ago by Mathieu Doucet

Re #5051 push the wrong file... fixing it now

Changeset: 443ee5aeea68a33b16d40a50e6a6aa5825c62b74

comment:25 Changed 8 years ago by Mathieu Doucet

Re #5051 removing unused file

Changeset: 0e5eab82cd81242efd952119df2f28aa31d517c6

comment:26 Changed 8 years ago by Russell Taylor

Re #5051. Fix MPI build.

Changeset: 61bc8a767140b139c92ddf528ee2bad8842e4f1c

comment:27 Changed 8 years ago by Mathieu Doucet

Re #5051 Added functionality to DataProcessorAlg

Changeset: 2fd6f57e553f781bb994d06baf28687a60768979

comment:28 Changed 8 years ago by mdoucet

Re #5051 exposed optional flag of workspace properties to python

Changeset: 18a7c77d67d419f9c07a2815ce8e0ac3c072db03

comment:29 Changed 8 years ago by Mathieu Doucet

Re #5051 Added EQSANS reduction example for mpi/live

Changeset: 4d8d370d455b553c44a0fabafafc73653a040d32

comment:30 Changed 8 years ago by Mathieu Doucet

Re #5051 Adding documentation

Changeset: fa2e1d9e70ec5d4efd07ceb306fd34033f507fa8

comment:31 Changed 8 years ago by Mathieu Doucet

Re #5051 Fixing missing or inaccurate documentation

Changeset: 45b4c61f1e6a88accb12ca546a07bd1ec2cac6a9

comment:32 Changed 8 years ago by Mathieu Doucet

Re #5051 Modify ComputeSensitivity to use DataProcessorAlg

Changeset: b786e944ffc3305af732e6942d063784989f5974

comment:33 Changed 8 years ago by Mathieu Doucet

Re #5051 Starting to fill in DataProcessorAlgorithm

Changeset: 8531b25f8d7decf00fa6c74e8915380c385f451d

comment:34 Changed 8 years ago by Mathieu Doucet

Re #5051 Prototype processor algorithm

Changeset: 878fb0cfd30d08c1d412ad71452b0fa598145b60

comment:35 Changed 8 years ago by Mathieu Doucet

Re #5051 push the wrong file... fixing it now

Changeset: 443ee5aeea68a33b16d40a50e6a6aa5825c62b74

comment:36 Changed 8 years ago by Mathieu Doucet

Re #5051 removing unused file

Changeset: 0e5eab82cd81242efd952119df2f28aa31d517c6

comment:37 Changed 8 years ago by Russell Taylor

Re #5051. Fix MPI build.

Changeset: 61bc8a767140b139c92ddf528ee2bad8842e4f1c

comment:38 Changed 8 years ago by Mathieu Doucet

Re #5051 Added functionality to DataProcessorAlg

Changeset: 2fd6f57e553f781bb994d06baf28687a60768979

comment:39 Changed 8 years ago by mdoucet

Re #5051 exposed optional flag of workspace properties to python

Changeset: 18a7c77d67d419f9c07a2815ce8e0ac3c072db03

comment:40 Changed 8 years ago by Mathieu Doucet

Re #5051 Added EQSANS reduction example for mpi/live

Changeset: 4d8d370d455b553c44a0fabafafc73653a040d32

comment:41 Changed 8 years ago by Mathieu Doucet

Re #5051 Adding documentation

Changeset: fa2e1d9e70ec5d4efd07ceb306fd34033f507fa8

comment:42 Changed 8 years ago by Mathieu Doucet

Re #5051 Fixing missing or inaccurate documentation

Changeset: 45b4c61f1e6a88accb12ca546a07bd1ec2cac6a9

comment:43 Changed 8 years ago by Mathieu Doucet

Re #5051 Modify ComputeSensitivity to use DataProcessorAlg

Changeset: b786e944ffc3305af732e6942d063784989f5974

comment:44 Changed 8 years ago by Michael Reuter

Refs #5051. Adding ability to set filename property for load.

One of the loaders that SNS supports, LoadEventPreNexus, does not use the Filename property. Therefore, I've made a way to set that.

Changeset: 3af1caa76aabfccdaedfb55d832365e1eaa9c37f

comment:45 Changed 8 years ago by Mathieu Doucet

Re #5051 Added EQSANS reduction example for mpi/live

Changeset: 4d8d370d455b553c44a0fabafafc73653a040d32

comment:46 Changed 8 years ago by Mathieu Doucet

Re #5051 Adding documentation

Changeset: fa2e1d9e70ec5d4efd07ceb306fd34033f507fa8

comment:47 Changed 8 years ago by Mathieu Doucet

Re #5051 Fixing missing or inaccurate documentation

Changeset: 45b4c61f1e6a88accb12ca546a07bd1ec2cac6a9

comment:48 Changed 8 years ago by Mathieu Doucet

Re #5051 Modify ComputeSensitivity to use DataProcessorAlg

Changeset: b786e944ffc3305af732e6942d063784989f5974

comment:49 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:50 Changed 8 years ago by Peter Peterson

  • Milestone changed from Release 2.3 to Release 2.4

comment:51 Changed 8 years ago by Peter Peterson

  • Milestone changed from Release 2.4 to Release 2.5

comment:52 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:53 Changed 7 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

This has been in master for a long time (10 months since last change during v2.2.0). If we need more features more tickets will be created.

No testing is necessary.

comment:54 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:55 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

I agree that there is no need for test. The last commit is about a year ago. The algorithms inheriting from DataProcessAlgorithm have been used for a long time without any issue related to this ticket. So the ticket is closed.

comment:56 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:57 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5897

Note: See TracTickets for help on using tickets.