Ticket #5058 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Add class to view Event workspaces, similar to ISAW's ImageView

Reported by: Dennis Mikkelson Owned by: Dennis Mikkelson
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: petersonpf@…, zikovskyjl@…, mikkelsonr@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

It will be useful to have a class to view collections of histograms as an image that can be scrolled both horizontally and vertically, and that provides graphs showing vertical and horizontal cuts through the data. This class should also provide for the easy selection of a color scale from a set of useful color scales, in addition to loading a color scale from a file. While the first implementation will be for event workspaces, the underlying viewer should be applicable to various other types of workspaces, with minimal effort.

Change History

comment:1 Changed 9 years ago by Dennis Mikkelson

Added initial version of ImageViewer.

The current version is not complete but is partially working with a test data source. refs #5058

Changeset: e9dadf1b7efcfc98be5d5ef7e9f1aba3d08cd506

comment:2 Changed 9 years ago by Dennis Mikkelson

Fixing duplicate name in ImageView.ui from Qt Designer

It worked on Linux, but VC doesn't like the duplicate name. refs #5058

Changeset: 904fb136ea9e704de43341aa27f8bda0f6124acf

comment:3 Changed 9 years ago by Dennis Mikkelson

Reverting CMakeLists.txt to NOT build ImageViewer

ImageViewer build is failing for some unknown reason on VC. Reverting for now and will deal with this tomorrow. refs #5058

Changeset: 5960918b0453839d92d071a133d08e10e5d754ae

comment:4 Changed 9 years ago by Dennis Mikkelson

Deleting ImageViewer/CMakeLists.txt to try to fix build

Since this is still not building correctly on VC, get rid of the lower level CMakeLists.txt, for now. refs #5058

Changeset: 4e3ce9a953efa46313bd75b03205da3df71f0b81

comment:5 Changed 9 years ago by Dennis Mikkelson

Adding CMakeLists.txt for ImageViewer.

Verify that this does not break build. refs #5058

Changeset: 6d6f004c661d8e9c1abbce16f707609760829a55

comment:6 Changed 9 years ago by Dennis Mikkelson

Adding DllOptionIV.h and updating for windows build.

Restoring CMakeLists.txt and adding DLL option info to all header files. Also removine ui_ImageView.h file that will be auto-generated from the ImageView.ui file during the build. refs #5058

Changeset: 39450465ab95269d1b8e17aa5600c81fab315208

comment:7 Changed 9 years ago by Dennis Mikkelson

Adding initial version of ImageDataSource using EventWorkspace

refs #5058

Changeset: b1ebe399383a44d5ef257ce5fccd10df43936a7b

comment:8 Changed 9 years ago by Dennis Mikkelson

Adding EventWSDataSource to CMakeLists

refs #5058

Changeset: d0b99ad6e2beb46728c1b8ac7f96791efc98acb3

comment:9 Changed 9 years ago by Dennis Mikkelson

Adding simple command line test for NeXus event file in ImageView

'make ImageViewNxEventFile' should compile the simple test program. The NeXus event file to load and view should be specified as the first argument on the command line. This is intended as an easy test program for use while the ImageViewer package is being developed. refs #5058

Changeset: 3708b0d512fedc6dcc6d35584d078296c5661ef6

comment:10 Changed 9 years ago by Dennis Mikkelson

ImageViewer now displays spectrum ID in tables.

refs #5058

Changeset: 5208cf6e409b9fb0aa6aca09325e6865a6284823

comment:11 Changed 9 years ago by Dennis Mikkelson

Added some more libraries to ImageViewer's CMakeLists.txt

Windows & Mac builds are failing with some libraries not being found. refs #5058

Changeset: 6029b9f5fc9667b0902311560d03297578cd9d52

comment:12 Changed 9 years ago by Dennis Mikkelson

Adding still more libraries to ImageView's CMakeLists

refs #5058

Changeset: 2625fb7c3f62048698032926bab7b3dff95cc8c4

comment:13 Changed 9 years ago by Dennis Mikkelson

Added choice of color scales to ImageView

refs #5058

Changeset: e04d5a4829f5f23850663b3c0b162fd8b291d4de

comment:14 Changed 9 years ago by Dennis Mikkelson

Delete QActionGroup in ImageView connections destructor.

refs #5058

Changeset: 9e7535d02db7f807e147cf301fe246d8bc437d31

comment:15 Changed 9 years ago by Dennis Mikkelson

Fixing reference to enum in ImageView for Snow Leopard build

refs #5058

Changeset: 596d4d1a71089ea09aced149a68aaab425f204f7

comment:16 Changed 8 years ago by Dennis Mikkelson

Added API docs to ImageViewer

refs #5058

Changeset: cd1ea0ff6eae9f302be8ef0db93586a1d894d795

comment:17 Changed 8 years ago by Dennis Mikkelson

Added API docs to ImageViewer

refs #5058

Changeset: cd1ea0ff6eae9f302be8ef0db93586a1d894d795

comment:18 Changed 8 years ago by Dennis Mikkelson

Attempt at fixing ambiguous reference to Matrix

Note: Larger change to add ImageView to menus was previously committed under ticket #5050 by mistake. refs #5058

Changeset: 4a83e9476768d131b7657cc763a97819ff52328e

comment:19 Changed 8 years ago by Dennis Mikkelson

Partly backing out adding ImageView to menu.

Adding ImageView to right click menu was working on Linux but fails on windows. There is an ambiguous type Matrix in MantidUI.cpp on the line: Matrix *m = appWindow()->newMatrix(rowNum,colNum); I don't currently know how to fix that. refs #5058

Changeset: ad92d30bbf4e2c0b0050a2a699504351dd657912

comment:20 Changed 8 years ago by Martyn Gigg

Remove DataObjects & DataHandling links from MantidPlot. Refs #5058

They're not needed & cause the mac app to fail to load.

Changeset: 6fa53cbdf3c1792df48edc4b926a311370e42a61

comment:21 Changed 8 years ago by Martyn Gigg

Add ImageViewer dll to windows installer. Refs #5058

Changeset: 1f8f6910de44186e49b1446be6260008e83e4fc9

comment:22 Changed 8 years ago by Dennis Mikkelson

Make ImageViewer start quickly.

Two changes were made to speed up the ImageViewer start:

  1. The ImageViewer got a full size data array including the full range of the data in the constructor. This was not needed and was responsible for 1/2 or more of the original start time, depending on the data size.
  2. An X-scale is no longer set on all spectra at start time since X-scales are set on the spectra that are actually drawn at the time the image data is obtained. There is no need to set all the X-scales initially. This took about 3-4 seconds at start time for an instrument with a large number of spectra (more than a million for SNAP). This was probably due to having to swap virtually all the spectra in and out of the MRU list.

refs #5058

Changeset: 7b3ffc3d9a88dfe1f4a6b7f68eb19b37049c2100

comment:23 Changed 8 years ago by Dennis Mikkelson

Attempt at fixing ambiguous reference to Matrix

Note: Larger change to add ImageView to menus was previously committed under ticket #5050 by mistake. refs #5058

Changeset: 4a83e9476768d131b7657cc763a97819ff52328e

comment:24 Changed 8 years ago by Dennis Mikkelson

Partly backing out adding ImageView to menu.

Adding ImageView to right click menu was working on Linux but fails on windows. There is an ambiguous type Matrix in MantidUI.cpp on the line: Matrix *m = appWindow()->newMatrix(rowNum,colNum); I don't currently know how to fix that. refs #5058

Changeset: ad92d30bbf4e2c0b0050a2a699504351dd657912

comment:25 Changed 8 years ago by Martyn Gigg

Remove DataObjects & DataHandling links from MantidPlot. Refs #5058

They're not needed & cause the mac app to fail to load.

Changeset: 6fa53cbdf3c1792df48edc4b926a311370e42a61

comment:26 Changed 8 years ago by Martyn Gigg

Add ImageViewer dll to windows installer. Refs #5058

Changeset: 1f8f6910de44186e49b1446be6260008e83e4fc9

comment:27 Changed 8 years ago by Dennis Mikkelson

Make ImageViewer start quickly.

Two changes were made to speed up the ImageViewer start:

  1. The ImageViewer got a full size data array including the full range of the data in the constructor. This was not needed and was responsible for 1/2 or more of the original start time, depending on the data size.
  2. An X-scale is no longer set on all spectra at start time since X-scales are set on the spectra that are actually drawn at the time the image data is obtained. There is no need to set all the X-scales initially. This took about 3-4 seconds at start time for an instrument with a large number of spectra (more than a million for SNAP). This was probably due to having to swap virtually all the spectra in and out of the MRU list.

refs #5058

Changeset: 7b3ffc3d9a88dfe1f4a6b7f68eb19b37049c2100

comment:28 Changed 8 years ago by Dennis Mikkelson

Quick hack: try to get image drawing on Win7

For some reason the image is not drawing consistently on Windows 7. It works fine on Linux and Mac. This is an attempt to see if there is a timing problem with drawing the image. refs #5058

Changeset: 238da311f5275899c4f3723d6b221425bd6a099d

comment:29 Changed 8 years ago by Dennis Mikkelson

Track thread to debug Windows 7 crash

Temporarily print out the thread ID of the thread being used for several Qt operations, to see if that might be the problem on Windows 7. refs #5058

Changeset: 7baf82545367a5dcdcb4ffdc7c53a40602db6a89

comment:30 Changed 8 years ago by Dennis Mikkelson

Threading not the problem on Win7, remove check.

refs #5058

Changeset: d0996c6930df7f3c94b772e74fe4d5d133f76138

comment:31 Changed 8 years ago by Dennis Mikkelson

Quick hack: try to get image drawing on Win7

For some reason the image is not drawing consistently on Windows 7. It works fine on Linux and Mac. This is an attempt to see if there is a timing problem with drawing the image. refs #5058

Changeset: 238da311f5275899c4f3723d6b221425bd6a099d

comment:32 Changed 8 years ago by Dennis Mikkelson

Track thread to debug Windows 7 crash

Temporarily print out the thread ID of the thread being used for several Qt operations, to see if that might be the problem on Windows 7. refs #5058

Changeset: 7baf82545367a5dcdcb4ffdc7c53a40602db6a89

comment:33 Changed 8 years ago by Dennis Mikkelson

Threading not the problem on Win7, remove check.

refs #5058

Changeset: d0996c6930df7f3c94b772e74fe4d5d133f76138

comment:34 Changed 8 years ago by Dennis Mikkelson

Try to fix Win7 crash: delete buffer later.

refs #5058

Changeset: 93d29de4004d0136e574919c6ff67a84c1627d9b

comment:35 Changed 8 years ago by Dennis Mikkelson

Added double buffer to ImagePlotItem.

Now use a double buffer for the DataArray passed into the ImagePlotItem, and have ImagePlotItem take ownership of the DataArray. Since ImagePlotItem will only delete a DataArray when it no longer needs it, this should avoid any possible problems with the system using a "stale" pointer to draw the image in response to window events. refs #5058

Changeset: e8ad872f564ef8ee59c06c768a38c706d86d9c63

comment:36 Changed 8 years ago by Dennis Mikkelson

  • Status changed from new to accepted

comment:37 Changed 8 years ago by Dennis Mikkelson

Partially implemented range and step controls.

Added initial partial test version of RangeHandler class to allow dynamic rebinning from the ImageViewer refs #5058

Changeset: de7b3f69f19a9c02b5c06a7c50381e3d28dfd186

comment:38 Changed 8 years ago by Dennis Mikkelson

Initialize min,max,step from DataSource.

refs #5058

Changeset: 6b47a7deb02b95d943170484134150764e18d6f7

comment:39 Changed 8 years ago by Dennis Mikkelson

ImageViewer:Uniform dynamic rebinning implemented

User can now specify min, max and step size to rebin and view the image dynamically. Currently only uniform bin sizes are supported. refs #5058

Changeset: 7c04e319702f0b93104d7c533d55184e8a2ad3ff

comment:40 Changed 8 years ago by Dennis Mikkelson

Use generateHistogram() to safely get Y-values

Added generateHistogram() to IEventList, and use it to get a clean copy of the Y-values, rebinned according to the required X-values. This does NOT modify the underlying data as setting an X-scale on the spectra did. It also seems to have fixed a couple of rare glitches that may have been related to the MRU list. refs #5058

Changeset: 556e433c16675ed5bd6d0d68a1191e0e357e3ab0

comment:41 Changed 8 years ago by Dennis Mikkelson

Remove 1us bin size limit.

Since the ImageViewer will be applied to EventWorkspaces that have been converted to other units, such as 'd', don't put a lower limit on 1 on the bin size. Now the total number of columns in the EventWSDataSource is set to 1,000,000, so the bin size can be as small as 1/1,000,000 of the total data width. refs #5058

Changeset: a72f79afb437fd5fa8e189b3f025fafbc17856ed

comment:42 Changed 8 years ago by Dennis Mikkelson

Try to fix Win7 crash: delete buffer later.

refs #5058

Changeset: 93d29de4004d0136e574919c6ff67a84c1627d9b

comment:43 Changed 8 years ago by Dennis Mikkelson

Added double buffer to ImagePlotItem.

Now use a double buffer for the DataArray passed into the ImagePlotItem, and have ImagePlotItem take ownership of the DataArray. Since ImagePlotItem will only delete a DataArray when it no longer needs it, this should avoid any possible problems with the system using a "stale" pointer to draw the image in response to window events. refs #5058

Changeset: e8ad872f564ef8ee59c06c768a38c706d86d9c63

comment:44 Changed 8 years ago by Dennis Mikkelson

Partially implemented range and step controls.

Added initial partial test version of RangeHandler class to allow dynamic rebinning from the ImageViewer refs #5058

Changeset: de7b3f69f19a9c02b5c06a7c50381e3d28dfd186

comment:45 Changed 8 years ago by Dennis Mikkelson

Initialize min,max,step from DataSource.

refs #5058

Changeset: 6b47a7deb02b95d943170484134150764e18d6f7

comment:46 Changed 8 years ago by Dennis Mikkelson

ImageViewer:Uniform dynamic rebinning implemented

User can now specify min, max and step size to rebin and view the image dynamically. Currently only uniform bin sizes are supported. refs #5058

Changeset: 7c04e319702f0b93104d7c533d55184e8a2ad3ff

comment:47 Changed 8 years ago by Dennis Mikkelson

Use generateHistogram() to safely get Y-values

Added generateHistogram() to IEventList, and use it to get a clean copy of the Y-values, rebinned according to the required X-values. This does NOT modify the underlying data as setting an X-scale on the spectra did. It also seems to have fixed a couple of rare glitches that may have been related to the MRU list. refs #5058

Changeset: 556e433c16675ed5bd6d0d68a1191e0e357e3ab0

comment:48 Changed 8 years ago by Dennis Mikkelson

Remove 1us bin size limit.

Since the ImageViewer will be applied to EventWorkspaces that have been converted to other units, such as 'd', don't put a lower limit on 1 on the bin size. Now the total number of columns in the EventWSDataSource is set to 1,000,000, so the bin size can be as small as 1/1,000,000 of the total data width. refs #5058

Changeset: a72f79afb437fd5fa8e189b3f025fafbc17856ed

comment:49 Changed 8 years ago by Dennis Mikkelson

Now adapts to change in underlying DataSource

If the underlying DataSource is changed, say by changing a TOF workspace to 'd', the ImageView just needs to be refreshed by moving a scroll bar or pressing return in one of the min,max,step controls. At that time, it will adjust to the new data range. refs #5058

Changeset: 430f87c35123b790e3ed6665770a22302429f677

comment:50 Changed 8 years ago by Dennis Mikkelson

Cleanup position readouts

Redundant info is no longer shown in readouts, and the info that is there has correct units from the workspace. Also, removed redundant calls to replot that were added in an earlier unsuccessful attempt at fixing a drawing problem on Windows. refs #5058

Changeset: 9dcab121ea52a1ce8a6634dc52d143dc69b6762d

comment:51 Changed 8 years ago by Dennis Mikkelson

Disable controls for un-implemented features

Since the ImageViewer is not yet complete, it will be less confusing for users if controls that don't do anything yet are turned off. refs #5058

Changeset: 738f0eb30f50dcd41ca500aa304b5626f55fc247

comment:52 Changed 8 years ago by Dennis Mikkelson

Close action implemented, free memory when closed

The close button now closes the main ImageView window and all objects created in the main are disposed of when the window is closed. refs #5058

Changeset: 855675262765d68a8c94227919a56f4a7931bdf1

comment:53 Changed 8 years ago by Dennis Mikkelson

No vertical scroll image now subsamples spectra

If the vertical scroll bar is turned off, the ImageViewer now displays an image obtained by selecting a subset of the available spectra. Specifically, if there are 5,000 spectra and 500 rows available in the image, the image is formed using every 10th spectrum. The results can be misleading due to aliasing, but at least it is possible to see if there are counts in the data. refs #5058

Changeset: 447c7d946129d11b17c462131b90910f01aae609

comment:54 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:55 Changed 8 years ago by Dennis Mikkelson

Adding classes so ImageViewer works for MatrixWorkspaces

Added MatrixWSDataSource and MatrixWSImageView classes, so ImageViewer can be applied to MatrixWorkspaces. A common base class for Matrix and Event workspace data sources should be created, or generateHistogram() should be added to IEventWorkspace. refs #5058

Changeset: 4e295d40012594a38baadd868f44adf70ec0599f

comment:56 Changed 8 years ago by Dennis Mikkelson

Trivial change to trigger rebuild

Build failed on XP for unrelated test. Added a line of documentation to trigger rebuild. refs #5058

Changeset: 2f239ef18ae79f1e3a39fd773143fe5563566f83

comment:57 Changed 8 years ago by Dennis Mikkelson

Re:5058 Minor code clean up

refs #5058

Changeset: e688b78137ef318e433698dd36490925ee5d3f1d

comment:58 Changed 8 years ago by Dennis Mikkelson

Re:5058 Use base class MatrixWorkspace in all cases

MantidUI will now just create an ImageViewer for a MatrixWorkspace, for both event workspaces and for Workspace2D. This works since generateHistogram() is now available for both types of MatrixWorkspace. refs #5058

Changeset: deb14773c3c79dc461519f5496183b13b5f368ad

comment:59 Changed 8 years ago by Dennis Mikkelson

RE: 5058 Add ArrayDataSource to easily show an array

The ArrayDataSource wraps a simple array of doubles stored in row major order, so the array can be viewed using the ImageViewer. This is a convenience class that should make it easy to apply the ImageViewer in other ways. Also, modified ImageViewDemo to use the new ArrayDataSource, as a demonstration of the new class. refs #5058

Changeset: b696fcbf4fb41b652014f73453cfcd918017ab0a

comment:60 Changed 8 years ago by Dennis Mikkelson

Re #5058 Add support for Log x-scales

If the user enters a meaningful negative step size, the image will be rebinned logarithmically in the x-direction and the horizontal graph will also be drawn with a log x-scale. refs #5058

Changeset: ad15236487f41d61a896ceb9517d9b0b1c56b668

comment:61 Changed 8 years ago by Dennis Mikkelson

Re 5058, Modify label on Step control to show how to use log scale

Refs #5058

Changeset: 3bfa8a0024d7ff625d069738bca858cbcc3ec4a5

comment:62 Changed 8 years ago by Dennis Mikkelson

Re: #5058 Remove files, replaced by newer versions

The versions of data source and image view that were specialized for event data are no longer needed, since these cases are now handled as matrix workspaces. They are treated polymorphically, using the generateHistogram method. The TestDataSource has been replaced with a generally useful ArrayDataSource class. refs #5058

Changeset: d90e417d02044301a7d0fe971420c0c022acd21e

comment:63 Changed 8 years ago by Dennis Mikkelson

Re: 5058 Image view now handles source that can't do log binning

The ArrayDataSource now correctly returns data with is_log_x false, since it does not support log binning. ImageDisplay now only switches to log scale for the x-axis if the data was successfully log binned. refs #5058

Changeset: a17a9cae0e9a514c8a325031ae6ee8891b9e22ff

comment:64 Changed 8 years ago by Dennis Mikkelson

Re: #5058 Fix possible error in value readout for vertical graph

Previously, both the x and y coordinates of a pointed at location on the graphs were both restricted to have valid data source coordinates. However, that was a mistake. For the horizontal graph, only the x-coordinate should be restricted and for the vertical graph, only the y-coordinate should be restricted. refs #5058

Changeset: ca347728a7c4c021694248015a33725d4c1bebec

comment:65 Changed 8 years ago by Dennis Mikkelson

Re 5058, Added messages if range values are adjusted

If the user specifies an invalid range or step, the values are reset and warning or error messages are logged. refs #5058

Changeset: 5304cd7511b37f0ee309d2db27f85236bfef7d71

comment:66 Changed 8 years ago by Dennis Mikkelson

Re: 5058, Graph max range control now implemented

The Graph Max slider is now active and allows the user to control what fraction of the range of values is actually graphed. This lets lower level features in the graph be magnified while the strongest peaks are clipped. refs #5058

Changeset: 91ec0d721dd8066c7e71e0ca6c74fc603c6dc767

comment:67 Changed 8 years ago by Dennis Mikkelson

Re #5058 Add support for Log x-scales

If the user enters a meaningful negative step size, the image will be rebinned logarithmically in the x-direction and the horizontal graph will also be drawn with a log x-scale. refs #5058

Changeset: ad15236487f41d61a896ceb9517d9b0b1c56b668

comment:68 Changed 8 years ago by Dennis Mikkelson

Re 5058, Modify label on Step control to show how to use log scale

Refs #5058

Changeset: 3bfa8a0024d7ff625d069738bca858cbcc3ec4a5

comment:69 Changed 8 years ago by Dennis Mikkelson

Re: #5058 Remove files, replaced by newer versions

The versions of data source and image view that were specialized for event data are no longer needed, since these cases are now handled as matrix workspaces. They are treated polymorphically, using the generateHistogram method. The TestDataSource has been replaced with a generally useful ArrayDataSource class. refs #5058

Changeset: d90e417d02044301a7d0fe971420c0c022acd21e

comment:70 Changed 8 years ago by Dennis Mikkelson

Re: 5058 Image view now handles source that can't do log binning

The ArrayDataSource now correctly returns data with is_log_x false, since it does not support log binning. ImageDisplay now only switches to log scale for the x-axis if the data was successfully log binned. refs #5058

Changeset: a17a9cae0e9a514c8a325031ae6ee8891b9e22ff

comment:71 Changed 8 years ago by Dennis Mikkelson

Re: #5058 Fix possible error in value readout for vertical graph

Previously, both the x and y coordinates of a pointed at location on the graphs were both restricted to have valid data source coordinates. However, that was a mistake. For the horizontal graph, only the x-coordinate should be restricted and for the vertical graph, only the y-coordinate should be restricted. refs #5058

Changeset: ca347728a7c4c021694248015a33725d4c1bebec

comment:72 Changed 8 years ago by Dennis Mikkelson

Re 5058, Added messages if range values are adjusted

If the user specifies an invalid range or step, the values are reset and warning or error messages are logged. refs #5058

Changeset: 5304cd7511b37f0ee309d2db27f85236bfef7d71

comment:73 Changed 8 years ago by Dennis Mikkelson

Re: 5058, Graph max range control now implemented

The Graph Max slider is now active and allows the user to control what fraction of the range of values is actually graphed. This lets lower level features in the graph be magnified while the strongest peaks are clipped. refs #5058

Changeset: 91ec0d721dd8066c7e71e0ca6c74fc603c6dc767

comment:74 Changed 8 years ago by Dennis Mikkelson

Re: 5058, Negative values now use separate color table

In order to easily distinguish between positive and negative values, a separate color table is now used for negative values. refs #5058

Changeset: d9819337bf7c866d969e70fb6854485ca5582961

comment:75 Changed 8 years ago by Dennis Mikkelson

Re 5058, Added display of color scale

A simple band of colors is used to display the color scale in use, with zero at the center of the display, colors for negative values to the left and colors for positive values to the right. refs #5058

Changeset: 3d06738ee88b96a08f0ba5c2f082689dd6ac5a56

comment:76 Changed 8 years ago by Dennis Mikkelson

Re 5058, delete local buffer

refs #5058

Changeset: 797b43055384f08ba653ebf949f1e4f16446fa41

comment:77 Changed 8 years ago by Dennis Mikkelson

Re 5058, Added messages if range values are adjusted

If the user specifies an invalid range or step, the values are reset and warning or error messages are logged. refs #5058

Changeset: 5304cd7511b37f0ee309d2db27f85236bfef7d71

comment:78 Changed 8 years ago by Dennis Mikkelson

Re: 5058, Graph max range control now implemented

The Graph Max slider is now active and allows the user to control what fraction of the range of values is actually graphed. This lets lower level features in the graph be magnified while the strongest peaks are clipped. refs #5058

Changeset: 91ec0d721dd8066c7e71e0ca6c74fc603c6dc767

comment:79 Changed 8 years ago by Dennis Mikkelson

Re: 5058, Negative values now use separate color table

In order to easily distinguish between positive and negative values, a separate color table is now used for negative values. refs #5058

Changeset: d9819337bf7c866d969e70fb6854485ca5582961

comment:80 Changed 8 years ago by Dennis Mikkelson

Re 5058, Added display of color scale

A simple band of colors is used to display the color scale in use, with zero at the center of the display, colors for negative values to the left and colors for positive values to the right. refs #5058

Changeset: 3d06738ee88b96a08f0ba5c2f082689dd6ac5a56

comment:81 Changed 8 years ago by Dennis Mikkelson

Re 5058, delete local buffer

refs #5058

Changeset: 797b43055384f08ba653ebf949f1e4f16446fa41

comment:82 Changed 8 years ago by Dennis Mikkelson

Re 5058, Added messages if range values are adjusted

If the user specifies an invalid range or step, the values are reset and warning or error messages are logged. refs #5058

Changeset: 5304cd7511b37f0ee309d2db27f85236bfef7d71

comment:83 Changed 8 years ago by Dennis Mikkelson

Re: 5058, Graph max range control now implemented

The Graph Max slider is now active and allows the user to control what fraction of the range of values is actually graphed. This lets lower level features in the graph be magnified while the strongest peaks are clipped. refs #5058

Changeset: 91ec0d721dd8066c7e71e0ca6c74fc603c6dc767

comment:84 Changed 8 years ago by Dennis Mikkelson

Re: 5058, Negative values now use separate color table

In order to easily distinguish between positive and negative values, a separate color table is now used for negative values. refs #5058

Changeset: d9819337bf7c866d969e70fb6854485ca5582961

comment:85 Changed 8 years ago by Dennis Mikkelson

Re 5058, Added display of color scale

A simple band of colors is used to display the color scale in use, with zero at the center of the display, colors for negative values to the left and colors for positive values to the right. refs #5058

Changeset: 3d06738ee88b96a08f0ba5c2f082689dd6ac5a56

comment:86 Changed 8 years ago by Dennis Mikkelson

Re 5058, delete local buffer

refs #5058

Changeset: 797b43055384f08ba653ebf949f1e4f16446fa41

comment:87 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Added more info to ImageView readouts

refs #5058

Changeset: 5ef8b5bf8d3851196259f0a38c71aa8ea9ad9d11

comment:88 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Added more info to ImageView readouts

refs #5058

Changeset: 5ef8b5bf8d3851196259f0a38c71aa8ea9ad9d11

comment:89 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Add check for Ein in run; add methods to DataArray

Check for Ein in run to find Emode. (Missing in cases I checked). Add convenience methods for converting between x and column and between y and row to the DataArray class. Simplify some code in ImageDisplay::UpdateImage. refs #5058

Changeset: 233a299699c956bccf581fd882c160319dcd740f

comment:90 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Add check for Ein in run; add methods to DataArray

Check for Ein in run to find Emode. (Missing in cases I checked). Add convenience methods for converting between x and column and between y and row to the DataArray class. Simplify some code in ImageDisplay::UpdateImage. refs #5058

Changeset: 233a299699c956bccf581fd882c160319dcd740f

comment:91 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Added scrolling of horizontal and vertical graphs.

The Horizontal graph will now scroll left/right as the image is scrolled left/right. The Vertical graph will now scroll up/down as the image is scrolled up/down. However, if the cut level is scrolled off the screen, the corresponding graph will not be drawn. refs #5058

Changeset: 4b253e24336bd3d2da85e8bc54118f48b95e45c1

comment:92 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Add check for Ein in run; add methods to DataArray

Check for Ein in run to find Emode. (Missing in cases I checked). Add convenience methods for converting between x and column and between y and row to the DataArray class. Simplify some code in ImageDisplay::UpdateImage. refs #5058

Changeset: 233a299699c956bccf581fd882c160319dcd740f

comment:93 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Added scrolling of horizontal and vertical graphs.

The Horizontal graph will now scroll left/right as the image is scrolled left/right. The Vertical graph will now scroll up/down as the image is scrolled up/down. However, if the cut level is scrolled off the screen, the corresponding graph will not be drawn. refs #5058

Changeset: 4b253e24336bd3d2da85e8bc54118f48b95e45c1

comment:94 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Added more info to ImageView readouts

refs #5058

Changeset: 5ef8b5bf8d3851196259f0a38c71aa8ea9ad9d11

comment:95 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Add check for Ein in run; add methods to DataArray

Check for Ein in run to find Emode. (Missing in cases I checked). Add convenience methods for converting between x and column and between y and row to the DataArray class. Simplify some code in ImageDisplay::UpdateImage. refs #5058

Changeset: 233a299699c956bccf581fd882c160319dcd740f

comment:96 Changed 8 years ago by Dennis Mikkelson

RE: 5058, Added scrolling of horizontal and vertical graphs.

The Horizontal graph will now scroll left/right as the image is scrolled left/right. The Vertical graph will now scroll up/down as the image is scrolled up/down. However, if the cut level is scrolled off the screen, the corresponding graph will not be drawn. refs #5058

Changeset: 4b253e24336bd3d2da85e8bc54118f48b95e45c1

comment:97 Changed 8 years ago by Dennis Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:98 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:99 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to closed

Very nice images from "Show Image Viewer". Easy to use and change color maps. This will help with checking calibration results.

comment:100 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5904

Note: See TracTickets for help on using tickets.