Ticket #5069 (closed: fixed)
Create workspace for polygon rebinning
| Reported by: | Michael Reuter | Owned by: | Michael Reuter |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
A new workspace needs to be created for handling the output of the polygon rebinning since there is the need to track the fraction overlap areas.
Change History
comment:2 Changed 8 years ago by Michael Reuter
Refs #5069. Adding start of rebinning output workspace.
Changeset: 94149559214b997bf1291218084f0fe9f3826232
comment:3 Changed 8 years ago by Michael Reuter
Refs #5069 and #5070. Updates to workspace and algorithm.
The rebinning workspace now has the fractional area tracking. This has been propogated to the necessary places in the algorithm for handling.
Changeset: 69407694d84f8682ba9aa26950d317a816e0bb47
comment:4 Changed 8 years ago by Michael Reuter
Refs #5069 and #5070. Updates to workspace and algorithm.
The rebinning workspace now has the fractional area tracking. This has been propogated to the necessary places in the algorithm for handling.
Changeset: 69407694d84f8682ba9aa26950d317a816e0bb47
comment:5 Changed 8 years ago by Michael Reuter
Refs #5069. Workspace can write to a processed NeXus file.
Changeset: b850567ed3cf38250a62fd2581ec78b0a7fbb9ac
comment:6 Changed 8 years ago by Michael Reuter
Refs #5069. Adding a setter and debugging info.
Changeset: f21e39f1ca10ba4c559bef817570433459ac6627
comment:7 Changed 8 years ago by Michael Reuter
Refs #5069. Adding test helper for workspace.
I've had to short-circuit the tests until I can figure out why I can't actually use the helper I've created.
Changeset: 2a0947ebe7c3224ed7651444a1463a7575f1927c
comment:8 Changed 8 years ago by Michael Reuter
Refs #5069. Fixed helper and uncommented tests.
Changeset: 96c557c07c6d9df3fa288c1095cad3e6749204fc
comment:9 Changed 8 years ago by Michael Reuter
Refs #5069. Fixing helper and testing more things on workspace.
Changeset: fdca34f74e8e79d41be84bf272f177b57a886634
comment:10 Changed 8 years ago by Michael Reuter
Refs #5069. Workspace can write to a processed NeXus file.
Changeset: b850567ed3cf38250a62fd2581ec78b0a7fbb9ac
comment:11 Changed 8 years ago by Michael Reuter
Refs #5069. Adding a setter and debugging info.
Changeset: f21e39f1ca10ba4c559bef817570433459ac6627
comment:12 Changed 8 years ago by Michael Reuter
Refs #5069. Adding test helper for workspace.
I've had to short-circuit the tests until I can figure out why I can't actually use the helper I've created.
Changeset: 2a0947ebe7c3224ed7651444a1463a7575f1927c
comment:13 Changed 8 years ago by Michael Reuter
Refs #5069. Fixed helper and uncommented tests.
Changeset: 96c557c07c6d9df3fa288c1095cad3e6749204fc
comment:14 Changed 8 years ago by Michael Reuter
Refs #5069. Fixing helper and testing more things on workspace.
Changeset: fdca34f74e8e79d41be84bf272f177b57a886634
comment:15 Changed 8 years ago by Michael Reuter
Refs #5069. Making SumSpectra work for RebinnedOutput workspace.
Changeset: aafd18430482b4e98746fe1341ff94ced6f9a5d7
comment:16 Changed 8 years ago by Michael Reuter
Refs #5069. Removing debugging statement.
Changeset: 4721447cabcaea1428eb81fce31f8fcf7dbe078b
comment:17 Changed 8 years ago by Michael Reuter
Refs #5069. Can now load a RebinnedOutput NeXus file.
Changeset: ac00f6b9fafe04a27152b05bb2163ba3f0db74a7
comment:18 Changed 8 years ago by Michael Reuter
Refs #5069. Transpose nearly works. Nans go missing though.
Changeset: 7187e927755f6fbbaa22284325cc1e80919c856f
comment:19 Changed 8 years ago by Michael Reuter
Refs #5069. Can use the workspace from Rebin2D.
An optional flag was added to use the fractional area tracking workspace. A RebinnedOutput workspace will returned from the algorithm.
Changeset: 794db01a142655267be2b43a1ac9905d0d507d41
comment:20 Changed 8 years ago by Michael Reuter
Refs #5069. Adding more Transpose tests.
Changeset: 067aa316a69abbc9efdca07a4a1d8ae1307462c8
comment:21 Changed 8 years ago by Michael Reuter
Refs #5069. Integration now works.
Changeset: 4449be70654f6a27e331d4f234c7bc1a8807064b
comment:22 Changed 8 years ago by Michael Reuter
Refs #5069. Try to make Windows happy.
Changeset: 57f85e0910628bf279ff4f0ec891930b1a931170
comment:23 Changed 8 years ago by Michael Reuter
Refs #5069. Correcting Integration implementation.
The old implementation performed the undo frac area, sum and redo frac area when calculating. It should actually be just a straight sum for Integration.
Changeset: 7214811f328c488805cec55c7ba75f544b213596
comment:24 Changed 8 years ago by Michael Reuter
Refs #5069. Streamlined Integration implementation.
Changeset: 6f20c5a66288d61209fca722e30cec8ce2780667
comment:25 Changed 8 years ago by Michael Reuter
Refs #5069. Don't let algorithm modify input data.
Changeset: 65cb783967901afd2419b74d15b40cef52e0f194
comment:26 Changed 8 years ago by Michael Reuter
Refs #5069. Making SumSpectra work for RebinnedOutput workspace.
Changeset: aafd18430482b4e98746fe1341ff94ced6f9a5d7
comment:27 Changed 8 years ago by Michael Reuter
Refs #5069. Removing debugging statement.
Changeset: 4721447cabcaea1428eb81fce31f8fcf7dbe078b
comment:28 Changed 8 years ago by Michael Reuter
Refs #5069. Can now load a RebinnedOutput NeXus file.
Changeset: ac00f6b9fafe04a27152b05bb2163ba3f0db74a7
comment:29 Changed 8 years ago by Michael Reuter
Refs #5069. Transpose nearly works. Nans go missing though.
Changeset: 7187e927755f6fbbaa22284325cc1e80919c856f
comment:30 Changed 8 years ago by Michael Reuter
Refs #5069. Can use the workspace from Rebin2D.
An optional flag was added to use the fractional area tracking workspace. A RebinnedOutput workspace will returned from the algorithm.
Changeset: 794db01a142655267be2b43a1ac9905d0d507d41
comment:31 Changed 8 years ago by Michael Reuter
Refs #5069. Adding more Transpose tests.
Changeset: 067aa316a69abbc9efdca07a4a1d8ae1307462c8
comment:32 Changed 8 years ago by Michael Reuter
Refs #5069. Integration now works.
Changeset: 4449be70654f6a27e331d4f234c7bc1a8807064b
comment:33 Changed 8 years ago by Michael Reuter
Refs #5069. Try to make Windows happy.
Changeset: 57f85e0910628bf279ff4f0ec891930b1a931170
comment:34 Changed 8 years ago by Michael Reuter
Refs #5069. Correcting Integration implementation.
The old implementation performed the undo frac area, sum and redo frac area when calculating. It should actually be just a straight sum for Integration.
Changeset: 7214811f328c488805cec55c7ba75f544b213596
comment:35 Changed 8 years ago by Michael Reuter
Refs #5069. Streamlined Integration implementation.
Changeset: 6f20c5a66288d61209fca722e30cec8ce2780667
comment:36 Changed 8 years ago by Michael Reuter
Refs #5069. Don't let algorithm modify input data.
Changeset: 65cb783967901afd2419b74d15b40cef52e0f194
comment:37 Changed 8 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to fixed
The best way of testing this it use the work in #5070 to generate on of these workspaces. Only a couple of algorithms have been modified to use this workspace, but it would be interesting to know what other ones need to be handled.
comment:38 Changed 8 years ago by Michael Reuter
- Status changed from verify to reopened
- Resolution fixed deleted
comment:40 Changed 8 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to fixed
Think this works for Rebin2D, but not sure about the other algorithms. That may need to wait.
comment:41 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:42 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
Confirmed that this works for SofQW3 and Rebin2D as the answers look sensible so it must be doing it's job properly.
comment:43 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5915
