Ticket #5071 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

New GUI needs to be designed to perform the REFL scaling factor calculation

Reported by: Jean Bilheux Owned by: Jean Bilheux
Priority: minor Milestone: Release 2.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Russell Taylor) (diff)

All the commits have been in Mantid since version 2.3 at least.

Change History

comment:1 Changed 9 years ago by Jean Bilheux

Started to implement the new REFL SF calculator gui and started to put it in place. This refs #5071"

Changeset: 78665f62ec0b2deab4cb6a5b3cb6b81829e93c10

comment:2 Changed 8 years ago by Jean Bilheux

Added a lot of stuff for the new REFL_SF_Calculator GUI. Work still in progress but that checking will make the error message disapear. This refs #5071"

Changeset: a39cc9c21575f9f38f326ad459c2975a9736bb0d

comment:3 Changed 8 years ago by Jean Bilheux

Added all new files that are required for the new REF_L_SF_calculator GUI. This refs #5071

Changeset: 0c2608e3b0e4e9fe11c053a826a80e018f434980

comment:4 Changed 8 years ago by Jean Bilheux

Finished up the interaction of the GUI. Still need to work on the Save List feature. This refs #5071

Changeset: b1ae2deb0ef9bc881273c238864d1941732c745a

comment:5 Changed 8 years ago by Mathieu Doucet

Re #5071 Fix UI layout to align widgets

Changeset: bb5163a03fc6656a80f7d5c6d856baab911ccd11

comment:6 Changed 8 years ago by Mathieu Doucet

Re #5071 Forgot a file in my last cleanup

Changeset: 55e7cccc60be381a5495cc2e55ca3eebfcc12f5b

comment:7 Changed 8 years ago by Jean Bilheux

Started to add connection to SAVE TO LIST. This refs #5071

Changeset: d928e4b6d2e38e46def790ce8c754c74d7b11678

comment:8 Changed 8 years ago by Jean Bilheux

Continued implementation of REFL_SF_calculator widgets. This refs #5071

Changeset: 6e985bad0d03977763cfe2eb0fc42f96a3976710

comment:9 Changed 8 years ago by Jean Bilheux

Open and save configuration works. This refs #5071

Changeset: a4a8b49173c2a414311bd1ec45c1357819937fa9

comment:10 Changed 8 years ago by Jean Bilheux

Code is ready to accept the command line to run the sf_calculator. This one needs to be slightly modified to works with the new GUI. This refs #5071

Changeset: 6c4c1b8e5f41c1257f975c953f6ec4d34167b379

comment:11 Changed 8 years ago by Jean Bilheux

Cleaned up some of the print statement. This refs #5071

Changeset: 7df0e5fd338ed5721b9ad44359d6cd0000c718e9

comment:12 Changed 8 years ago by Jean Bilheux

Forgot to remove a print statement. This refs #5071

Changeset: a7e3e210e06ebf47d2a7b1d339551e6da6ff8994

comment:13 Changed 8 years ago by Jean Bilheux

Forgot to remove a print statement. This refs #5071

Changeset: a7e3e210e06ebf47d2a7b1d339551e6da6ff8994

comment:14 Changed 8 years ago by Mathieu Doucet

Re #5071 clean up unused files

Changeset: 3419d14deaaeac2014fa57476b9188f2ad9e9a30

comment:15 Changed 8 years ago by Mathieu Doucet

Re #5071 expose polarization option on algo UI

Changeset: 2ca9f47e12a8e35a1f2056965f606732adc343da

comment:16 Changed 8 years ago by Mathieu Doucet

Re #5071 remove print statements

Changeset: 771195cec48afa74fb2892e1c6a27d608f3f66c0

comment:17 Changed 8 years ago by Mathieu Doucet

Re #5071 fix sample log reads for REFL

Changeset: 922b2a10f9b79046cb34d17d76658c69fc23b61b

comment:18 Changed 8 years ago by Mathieu Doucet

Re #5071 remove print statement

Changeset: 56d855fce5ff0e1c98531bf9143b7bf76c34fd3a

comment:19 Changed 8 years ago by Mathieu Doucet

Re #5071 clean up unused files

Changeset: 3419d14deaaeac2014fa57476b9188f2ad9e9a30

comment:20 Changed 8 years ago by Mathieu Doucet

Re #5071 expose polarization option on algo UI

Changeset: 2ca9f47e12a8e35a1f2056965f606732adc343da

comment:21 Changed 8 years ago by Mathieu Doucet

Re #5071 fix sample log reads for REFL

Changeset: 922b2a10f9b79046cb34d17d76658c69fc23b61b

comment:22 Changed 8 years ago by Mathieu Doucet

Re #5071 remove print statement

Changeset: 56d855fce5ff0e1c98531bf9143b7bf76c34fd3a

comment:23 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:24 Changed 8 years ago by Jean Bilheux

Started to make code GUI compatible (add new parameters...). This refs #5071

Changeset: d0d2ba4846a37396541bb9db099119c88c6036b9

comment:25 Changed 8 years ago by Jean Bilheux

Fixed issue with the way some of the workspace were cleared in REFL_reduction. Added infos messages to REFLSFcalculator and still working on making the code GUI compatible. This refs #4303 #5071

Changeset: 26af31e334034e4d16d9bcab877f8ee260609cb2

comment:26 Changed 8 years ago by Jean Bilheux

Script is now command line compatible. Now I need to adapt the GUI to call this command line. This refs #5071.

Changeset: d28d6bafa6c8f916dd9b6226cc20d516310cc25b

comment:27 Changed 8 years ago by Jean Bilheux

sfCalculator is now ready to be implemented in the GUI. Code now generate the RefLsf.cfg file and replace new entry only if those values are not within a range predefined by IS. This refs #5071

Changeset: 091379792bf1b5ee6e34a7835f2e4f16fc3d2015

comment:28 Changed 8 years ago by Jean Bilheux

Added new input parameters requested for the configuration file (Incident Medium). This refs #5071

Changeset: dd79ff5e2d8317ceef27b11183b3e713281e12e6

comment:29 Changed 8 years ago by Jean Bilheux

Work in progress to create executable command to run sfCalculator. This refs #5071

Changeset: 383439a8bd3b6fbd400e8229cfdc466a978e4ad7

comment:30 Changed 8 years ago by Jean Bilheux

Continued work on adding new script. This refs #5071

Changeset: dbb81ee7e028417c6e22683405dcfbc0714db094

comment:31 Changed 8 years ago by Jean Bilheux

sfCalculator can now be run from the command line or from the GUI. Config file is created and new fields are populated only if previous field with same condition does not exist. This refs #5071

Changeset: 13714a5e084b79d8bd09d71773bb58635207eab2

comment:32 Changed 8 years ago by Jean Bilheux

Moved file to final location. This refs #5071

Changeset: 6eaf81e534336001850dede9913cb0f5daa930db

comment:33 Changed 8 years ago by Jean Bilheux

Removed print statement used for debugging. This refs #5071

Changeset: 19a107c43b2a8f813b225077f8e43f759f3eb7c0

comment:34 Changed 8 years ago by Jean Bilheux

Started to modify the RefLReduction to take into account the new tags and format of the config file. This refs #4303 #5071

Changeset: cae894eba90881c6555962e6c08f6c9b6f3b12f9

comment:35 Changed 8 years ago by Jean Bilheux

Added safeguard around config file name. This refs #5071

Changeset: c7a5d2b25b6f03391344177bb7b58f81b8950b73

comment:36 Changed 8 years ago by Jean Bilheux

Addd browse button to GUI. User can now define the path to config. file name. This refs #5071

Changeset: 883f07b6d4787812653a4885a167356b7700204f

comment:37 Changed 8 years ago by Jean Bilheux

Started to modify code to make sure global variables stay global. This refs #5071

Changeset: 5a97faeb8a99f87910c591db09fd7e69e3ba1a4b

comment:38 Changed 8 years ago by Jean Bilheux

Implemented global parameters. Now, Incident medium, TOF min and TOF max are not related to any of the angle list but are global. This refs #5071

Changeset: 7a2c9fbebb58e8b941c8fcf62fb29646eda65dcf

comment:39 Changed 8 years ago by Jean Bilheux

Removed all the print statement. This refs #5071

Changeset: 78bf04bf14c3b482d9887d1a3039992b5fca6570

comment:40 Changed 8 years ago by Jean Bilheux

Fixed various error showing up because of the pylab import gone. This refs #5071

Changeset: fed30a519e8112d930392cb2427c9ac2672f84ff

comment:41 Changed 8 years ago by Jean Bilheux

Added full configuration of the output file name. this refs #5071

Changeset: ee32d3e12c2cb25058cf5f8f5003e27ded67df32

comment:42 Changed 8 years ago by Jean Bilheux

Improved interaction when changing name of output file. Application is now ready to be fully tested. This refs #5071

Changeset: 124c8c0fa5f63778b8df233711d68e91bf0235e2

comment:43 Changed 8 years ago by Jean Bilheux

Added new widgets to RefLReduction GUI (incident medium and scaling factor configuration file). Started to implement widgets. This refs #5071

Changeset: c5fa8d43e17a149d7ca2b3588dbf8c2efe7ca25d

comment:44 Changed 8 years ago by Jean Bilheux

Added global variables to REFL reduction gui (just like it has been done with sfCalculator). Still need to make the connection in the back (to the algorithm). This refs #5071

Changeset: 37af662db11c605d032684138aaa08aa6a7a488d

comment:45 Changed 8 years ago by Jean Bilheux

Implemented back side of GUI. Now application used global new variables such as incident medium, sfConfig file and more. This refs #5071

Changeset: 3b076a01573d01abe87468788ee5700a33b7c52b

comment:46 Changed 8 years ago by Jean Bilheux

Last small modifications before testing by IS and friendy users. This refs #5071

Changeset: 4d0fd6489b9c937c357e2c382a60d67812e45a68

comment:47 Changed 8 years ago by Jean Bilheux

Last small modifications before testing by IS and friendy users. This refs #5071

Changeset: 4d0fd6489b9c937c357e2c382a60d67812e45a68

comment:48 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium list that crashed the program (due to format error). This refs #5071

Changeset: 51b072e3ac8b057939d6a4853c9eacf32c32e749

comment:49 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium index and list. This refs #5071

Changeset: 29f5d0476e30f1ef5cb160ab089aa541992db633

comment:50 Changed 8 years ago by Jean Bilheux

Offset of string array was off. This refs #5071

Changeset: a248b20dd492e9ef649cf009eeaeeee6614d0672

comment:51 Changed 8 years ago by Jean Bilheux

Added safe guard that check if there is a scaling factor file name defined before running the reduction. This refs #5071

Changeset: bd3e9aa9b9aef405b12c0e91d58f947b2636d72e

comment:52 Changed 8 years ago by Jean Bilheux

Fixed issue with format of Scaling factor file format. Before, because the programs was trying to find any matched entries, if the format was wrong, the new entries were not recorded.... Now, if the format is wrong, the containt of the file is simply replaced by the new entries. This refs #5071

Changeset: aff217781a1fc9cc0f0334a5fd67bba41f9121d8

comment:53 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium that was wrongly parsed. This refs #5071

Changeset: f1445dbf21efc1cd09c25eb0d861d6c370b506a2

comment:54 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium list that crashed the program (due to format error). This refs #5071

Changeset: 51b072e3ac8b057939d6a4853c9eacf32c32e749

comment:55 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium index and list. This refs #5071

Changeset: 29f5d0476e30f1ef5cb160ab089aa541992db633

comment:56 Changed 8 years ago by Jean Bilheux

Offset of string array was off. This refs #5071

Changeset: a248b20dd492e9ef649cf009eeaeeee6614d0672

comment:57 Changed 8 years ago by Jean Bilheux

Added safe guard that check if there is a scaling factor file name defined before running the reduction. This refs #5071

Changeset: bd3e9aa9b9aef405b12c0e91d58f947b2636d72e

comment:58 Changed 8 years ago by Jean Bilheux

Fixed issue with format of Scaling factor file format. Before, because the programs was trying to find any matched entries, if the format was wrong, the new entries were not recorded.... Now, if the format is wrong, the containt of the file is simply replaced by the new entries. This refs #5071

Changeset: aff217781a1fc9cc0f0334a5fd67bba41f9121d8

comment:59 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium that was wrongly parsed. This refs #5071

Changeset: f1445dbf21efc1cd09c25eb0d861d6c370b506a2

comment:60 Changed 8 years ago by Jean Bilheux

Improved interaction with gui when loading data run. Loading configurationf file with a SF file defined will now refresh the preview of that file. This refs #5071

Changeset: ad9dd9005cf48dddb3ad4cee5a12b7baca7e2ceb

comment:61 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium list that crashed the program (due to format error). This refs #5071

Changeset: 51b072e3ac8b057939d6a4853c9eacf32c32e749

comment:62 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium index and list. This refs #5071

Changeset: 29f5d0476e30f1ef5cb160ab089aa541992db633

comment:63 Changed 8 years ago by Jean Bilheux

Offset of string array was off. This refs #5071

Changeset: a248b20dd492e9ef649cf009eeaeeee6614d0672

comment:64 Changed 8 years ago by Jean Bilheux

Added safe guard that check if there is a scaling factor file name defined before running the reduction. This refs #5071

Changeset: bd3e9aa9b9aef405b12c0e91d58f947b2636d72e

comment:65 Changed 8 years ago by Jean Bilheux

Fixed issue with format of Scaling factor file format. Before, because the programs was trying to find any matched entries, if the format was wrong, the new entries were not recorded.... Now, if the format is wrong, the containt of the file is simply replaced by the new entries. This refs #5071

Changeset: aff217781a1fc9cc0f0334a5fd67bba41f9121d8

comment:66 Changed 8 years ago by Jean Bilheux

Fixed issue with incident medium that was wrongly parsed. This refs #5071

Changeset: f1445dbf21efc1cd09c25eb0d861d6c370b506a2

comment:67 Changed 8 years ago by Jean Bilheux

Improved interaction with gui when loading data run. Loading configurationf file with a SF file defined will now refresh the preview of that file. This refs #5071

Changeset: ad9dd9005cf48dddb3ad4cee5a12b7baca7e2ceb

comment:68 Changed 8 years ago by Jean Bilheux

Did some cleanup. This refs #4303 #5071

Changeset: 0fde9e83a71b896472bf7dc00321dbd281e0242d

comment:69 Changed 8 years ago by Jean Bilheux

Did some cleanup. This refs #4303 #5071

Changeset: 0fde9e83a71b896472bf7dc00321dbd281e0242d

comment:70 Changed 8 years ago by Jean Bilheux

Changed precision of match for slits. Double it. This refs #4303 #5071

Changeset: e27dc51e5aea02816f2ef7c5db34a7c2bd17ff30

comment:71 Changed 8 years ago by Jean Bilheux

Fixed a typo... . This refs #5071

Changeset: 1dd6d903c77d57278f10719ca3b98fa1a214b67c

comment:72 Changed 8 years ago by Jean Bilheux

Now program keeps memory of the last incident medium list/index and sf config file name. This refs #5071

Changeset: 1011e8747528abee9db02a7dba7fc887d461235e

comment:73 Changed 8 years ago by Jean Bilheux

Removed un-necessary lines. This refs #5071

Changeset: d4e78a32d529f4c31cf51dc6e2aeef371d042ba0

comment:74 Changed 8 years ago by Jean Bilheux

Removed annoying print statement. This refs #5071

Changeset: 1ddbe45ef8fe0c3fe63604697784c921ad4cdd58

comment:75 Changed 8 years ago by Jean Bilheux

Changed precision of match for slits. Double it. This refs #4303 #5071

Changeset: e27dc51e5aea02816f2ef7c5db34a7c2bd17ff30

comment:76 Changed 8 years ago by Jean Bilheux

Fixed a typo... . This refs #5071

Changeset: 1dd6d903c77d57278f10719ca3b98fa1a214b67c

comment:77 Changed 8 years ago by Jean Bilheux

Now program keeps memory of the last incident medium list/index and sf config file name. This refs #5071

Changeset: 1011e8747528abee9db02a7dba7fc887d461235e

comment:78 Changed 8 years ago by Jean Bilheux

Removed un-necessary lines. This refs #5071

Changeset: d4e78a32d529f4c31cf51dc6e2aeef371d042ba0

comment:79 Changed 8 years ago by Jean Bilheux

Removed annoying print statement. This refs #5071

Changeset: 1ddbe45ef8fe0c3fe63604697784c921ad4cdd58

comment:80 Changed 8 years ago by Jean Bilheux

Improved interaction with gui when loading data run. Loading configurationf file with a SF file defined will now refresh the preview of that file. This refs #5071

Changeset: ad9dd9005cf48dddb3ad4cee5a12b7baca7e2ceb

comment:81 Changed 8 years ago by Jean Bilheux

Did some cleanup. This refs #4303 #5071

Changeset: 0fde9e83a71b896472bf7dc00321dbd281e0242d

comment:82 Changed 8 years ago by Jean Bilheux

Changed precision of match for slits. Double it. This refs #4303 #5071

Changeset: e27dc51e5aea02816f2ef7c5db34a7c2bd17ff30

comment:83 Changed 8 years ago by Jean Bilheux

Fixed a typo... . This refs #5071

Changeset: 1dd6d903c77d57278f10719ca3b98fa1a214b67c

comment:84 Changed 8 years ago by Jean Bilheux

Now program keeps memory of the last incident medium list/index and sf config file name. This refs #5071

Changeset: 1011e8747528abee9db02a7dba7fc887d461235e

comment:85 Changed 8 years ago by Jean Bilheux

Removed un-necessary lines. This refs #5071

Changeset: d4e78a32d529f4c31cf51dc6e2aeef371d042ba0

comment:86 Changed 8 years ago by Jean Bilheux

Removed annoying print statement. This refs #5071

Changeset: 1ddbe45ef8fe0c3fe63604697784c921ad4cdd58

comment:87 Changed 8 years ago by Jean Bilheux

Fixed issue with plot in SF gui. This refs #5071

Changeset: 593721d398101532a349619cc72ad8c7f78d92de

comment:88 Changed 8 years ago by Jean Bilheux

Removed annoying print statement. This refs #5071

Changeset: 1ddbe45ef8fe0c3fe63604697784c921ad4cdd58

comment:89 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

comment:90 Changed 8 years ago by Jean Bilheux

Added better resolution of fittng parameters. This refs #5071.

Changeset: f6ee02b7adb9b17de47fb9a995f0d11c5399ca2f

comment:91 Changed 8 years ago by Jean Bilheux

Added better resolution of fittng parameters. This refs #5071.

Changeset: f6ee02b7adb9b17de47fb9a995f0d11c5399ca2f

comment:92 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:93 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:94 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:95 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:96 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:97 Changed 7 years ago by Russell Taylor

  • Status changed from new to assigned

comment:98 Changed 7 years ago by Jean Bilheux

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:99 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:100 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed
  • Description modified (diff)
  • Milestone changed from Backlog to Release 2.3

comment:101 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5917

Note: See TracTickets for help on using tickets.