Ticket #5084 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

GeneratePeaks

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

FindPeaks needs a companion algorithm that takes

  • TableWorkspace of "RawPeakParameters"
  • PeakFunction to be used for generating peaks
  • InputWorkspace (optional) to take information for the instrument, and where to evaluate the x-axis
  • Binning (optional) of where to evaluate the x-axis. Either this or the InputWorkspace need to be specified
  • OutputWorkspace to put the data into
  • GeneratePeaks (bool) whether or not to generate the peaks
  • GenerateBackground (bool) whether or not to generate the background

This will first be used to diagnose peak finding and calibration, but can later be used in StripPeaks to simplify the code.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

Implement (but not finish) GeneratePeaks. Refs #5084.

Changeset: 741a1e07ccd38db8d9587de9b70354de0c9216c1

comment:2 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Wenduo Zhou

Improve performance. Refs #5084.

Changeset: 401bc95e5e68b48b547a2fa40471a0d58f994162

comment:4 Changed 8 years ago by Wenduo Zhou

Fix for windows. Refs #5084.

Changeset: f77f55c947379c354703829487957e9ae8ea80a9

comment:5 Changed 8 years ago by Wenduo Zhou

More on unit test. Refs #5084.

Complete the unit test on GeneratePeaks.

Changeset: 719891b2a1d44739f4c808bb50fdef956e6bdb91

comment:6 Changed 8 years ago by Peter Peterson

Refs #5084. Redid the math for unit tests with a calculater.

Changeset: fcb278e329e66fc23f7617d5c6f778da26eadf52

comment:7 Changed 8 years ago by Peter Peterson

Refs #5084. Only evaluate the peaks within a range around the peak.

Changeset: 37de8cd4c1a8c288301b06da6b8f9fd8a4c61dc9

comment:8 Changed 8 years ago by Peter Peterson

Refs #5084. Turned openmp pragmas back on.

Changeset: dbd7b0cd8d4c58c50498a9e7b759576f87d63f89

comment:9 Changed 8 years ago by Peter Peterson

Refs #5084. Make the rebin parameters optional.

Changeset: b90b2b5c86417d73d4dd6761362f552a0afe9c79

comment:10 Changed 8 years ago by Peter Peterson

Refs #5084. Refactored code for raw and effective peak parameters.

Changeset: cefd6c4aec3a5fc1684db531760f0bed6907c5d4

comment:11 Changed 8 years ago by Peter Peterson

Refs #5084. Redid the math for unit tests with a calculater.

Changeset: fcb278e329e66fc23f7617d5c6f778da26eadf52

comment:12 Changed 8 years ago by Peter Peterson

Refs #5084. Only evaluate the peaks within a range around the peak.

Changeset: 37de8cd4c1a8c288301b06da6b8f9fd8a4c61dc9

comment:13 Changed 8 years ago by Peter Peterson

Refs #5084. Turned openmp pragmas back on.

Changeset: dbd7b0cd8d4c58c50498a9e7b759576f87d63f89

comment:14 Changed 8 years ago by Peter Peterson

Refs #5084. Make the rebin parameters optional.

Changeset: b90b2b5c86417d73d4dd6761362f552a0afe9c79

comment:15 Changed 8 years ago by Peter Peterson

Refs #5084. Refactored code for raw and effective peak parameters.

Changeset: cefd6c4aec3a5fc1684db531760f0bed6907c5d4

comment:16 Changed 8 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:18 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to verify
  • Tester Roman Tolchenov deleted

comment:19 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:20 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

If InputWorkspace is histogram data and a peak is wide enough to reach the end of the x range the algorithm crashes with a vector index out of range error. Also to notice: values are calculated at bin boundaries rather than at bin centres and the binning parameters seem to have no effect.

comment:21 Changed 8 years ago by Peter Peterson

  • Owner changed from Wenduo Zhou to Peter Peterson
  • Status changed from reopened to accepted
  • Milestone changed from Release 2.1 to Release 2.2

comment:22 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:23 Changed 8 years ago by Peter Peterson

  • Milestone changed from Release 2.3 to Release 2.4

comment:24 Changed 8 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

The problems that Roman saw in testing is now in ticket #6423.

comment:25 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Wenduo Zhou

comment:26 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5930

Note: See TracTickets for help on using tickets.