Ticket #5101 (closed: fixed)
Add number of masked to MaskWorkspace data
Reported by: | Michael Reuter | Owned by: | Michael Reuter |
---|---|---|---|
Priority: | minor | Milestone: | Release 2.2 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Wenduo Zhou |
Description
An entry should be added to the workspace data information in the Workspaces area for MaskWorkspaces. That entry should be the number of masked items in the workspace.
Change History
comment:2 Changed 8 years ago by Michael Reuter
Refs #5101. Adding masked entry for MaskWorkspace data.
Changeset: 8cb53853430698a6a9dfc51d37c28b7aa59e1b13
comment:3 Changed 8 years ago by Michael Reuter
Refs #5101. Adding masked entry for MaskWorkspace data.
Changeset: 8cb53853430698a6a9dfc51d37c28b7aa59e1b13
comment:4 Changed 8 years ago by Martyn Gigg
Revert "Refs #5101. Adding masked entry for MaskWorkspace data."
This reverts commit 8cb53853430698a6a9dfc51d37c28b7aa59e1b13. This commit add a link from MantidPlot to a plugin library which is not allowed as MantidPlot should only see things at API level.
Changeset: 6beaaf779c090f30a6ca6134262900f9f28cca4d
comment:5 Changed 8 years ago by Martyn Gigg
Michael, I had to revert this as an installed MantidPlot would not start on Windows sinceDataObjects is not located in the bin directory and therefore cannot be found by the dll loader.
We have a policy that MantidPlot should only link to API and below to maintain flexibility. This means each that a type like MaskWorkspace is also going to need an interface to be created before it can be use in the GUI.
Another option I thought of was moving where we generate the information about a workspace. At the moment MantidPlot checks for each type and generates the information, which was okay when we had one type of workspace but it's very brittle now. If the DataObject interface had some kind of "describe" method that just returned a string containing the information that is currently generated by MantidPlot then MantidPlot would never have to be changed again, it would simply call describe & process the string (probably just split lines up to created the entries). Each new type can then implement describe as best suited to it.
This is obviously a much a larger piece of work so should probably have its own ticket and I guess may not get done for this iteration.
comment:6 Changed 8 years ago by Martyn Gigg
Revert "Refs #5101. Adding masked entry for MaskWorkspace data."
This reverts commit 8cb53853430698a6a9dfc51d37c28b7aa59e1b13. This commit add a link from MantidPlot to a plugin library which is not allowed as MantidPlot should only see things at API level.
Changeset: 6beaaf779c090f30a6ca6134262900f9f28cca4d
comment:7 Changed 8 years ago by Michael Reuter
I think this also points to another problem that our inheritance tree for workspaces is becoming too deep and too bloated for its own good.
comment:9 Changed 8 years ago by Peter Peterson
Refs #5101. Added masked entry for MaskWorkspace data.
This time Martin should be happier as there is an interface class in API so packages stay as they were.
Changeset: 814e6645c26c50de1fac1b3c1a69e31008e188aa
comment:10 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:11 Changed 8 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5947