Ticket #5111 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Fit interface has changed & is no longer compatible with generic python wrapper

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description

Fit is now much more like the Load algorithm in that its properties are not static, they depend on the type of data source passed in.

It will need a specific function in the simple API calls just like load.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

  • Summary changed from Fit interface has changed & is no longer compatibe with generic python wrapper to Fit interface has changed & is no longer compatible with generic python wrapper

comment:3 Changed 8 years ago by Martyn Gigg

Implement Fit as a specialized simple function in Python. Refs #5111

It has requirements of argument ordering & accepting more arguments than its initial properties specify. Refactored some common code & created more tests at the same time.

Changeset: 674d18d8c8758ffe1f14bfc6da4b3aaa056b0357

comment:4 Changed 8 years ago by Martyn Gigg

Disable test while crash occurs on OS X. Refs #5111

Changeset: 97718b5bb1a2e899fdc16c625c1ba3ca3fffc680

comment:5 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Martyn Gigg

Implement Fit as a specialized simple function in Python. Refs #5111

It has requirements of argument ordering & accepting more arguments than its initial properties specify. Refactored some common code & created more tests at the same time.

Changeset: 674d18d8c8758ffe1f14bfc6da4b3aaa056b0357

comment:7 Changed 8 years ago by Martyn Gigg

Disable test while crash occurs on OS X. Refs #5111

Changeset: 97718b5bb1a2e899fdc16c625c1ba3ca3fffc680

comment:8 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:9 Changed 8 years ago by Alex Buts

Python script runs Fit algorithm correctly and no crashes observed on Windows.

There are problems with history generation, referred by ticket #5180

comment:10 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5957

Note: See TracTickets for help on using tickets.