Ticket #5112 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

syntax error in Python script may crash Mantid under win64, release mode.

Reported by: Alex Buts Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Martyn Gigg) (diff)

The script below has syntax error. The algorithm called by the last string of the script has wrong signature.

Instead of reporting an error, it mainly crashes Mantid. But sometimes it reports error in the first row of the python script.

print 'start\n'
cur_ws='wsn';
md_ws='mdws4D';
MDWSF='';
print 'for\n'
for n in range(15052,15179):
	print 'Load\n'	
#        LoadNXSPE(Filename='D:/Data/Fe/Fe_Mantid/MAP'+str(n)+'.nxspe',OutputWorkspace=cur_ws)
	print 'SetUB\n'		
#	SetUB(Workspace=cur_ws,a='2.87',b='2.87',c='2.87')
	#ConvertToMDEvents(InputWorkspace=cur_ws,OutputWorkspace=md_ws,QDimensions='Q3D',UsePreprocessedDetectors='1',MinValues='-4.2,-4.2,-4.2,-50',MaxValues='4.2,4.2,4.2,350',SplitInto='50',MaxRecursionDepth='1',MinRecursionDepth='1')
#	SaveMD(md_ws,'MDMAP'+str(n)+'.nxs');
#	DeleteWorkspace(md_ws);
#	DeleteWorkspace(cur_ws);	
	MDWSF=MDWSF+'MDMAP'+str(n)+'.nxs;';

MergeMDFiles(MDWSF,'ws2',OutputFilename='fe400_8k.nxs',Parallel='1',OutputFilename='fe400_8k.nxs');

Attachments

BuildSQW.py (841 bytes) - added by Alex Buts 8 years ago.

Change History

Changed 8 years ago by Alex Buts

comment:1 Changed 8 years ago by Martyn Gigg

  • Description modified (diff)

comment:2 Changed 8 years ago by Martyn Gigg

Fix issues with syntax errors on Windows. Refs #5112

Also improved the information you get when one is generated.

Changeset: 29fe8cbb376dcefca58164d569e60d2d81b5c017

comment:3 Changed 8 years ago by Martyn Gigg

Fix build error that windows allowed. Refs #5112

Changeset: b59a7d68d2596aa755963f90b1a8434ccdc01eec

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Martyn Gigg

Fix issues with syntax errors on Windows. Refs #5112

Also improved the information you get when one is generated.

Changeset: 29fe8cbb376dcefca58164d569e60d2d81b5c017

comment:7 Changed 8 years ago by Martyn Gigg

Fix build error that windows allowed. Refs #5112

Changeset: b59a7d68d2596aa755963f90b1a8434ccdc01eec

comment:8 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Ran the script, added other syntax errors, no crash

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5958

Note: See TracTickets for help on using tickets.