Ticket #5133 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Get IntegratePeakTimeSlices working again

Reported by: Vickie Lynch Owned by: Ruth Mikkelson
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: roman.tolchenov@…, MikkelsonR@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

Fitting changes broke test and SNSSingleCrystalReduction.

Change History

comment:1 Changed 8 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Vickie Lynch

Refs #5133 Test working again

Changeset: c0becbb3f503cb80dd30a2b3acbea6bbf2e07545

comment:3 Changed 8 years ago by Vickie Lynch

Refs #5133 need to fix sigma; remove from test

Changeset: 18627b5b5a3f2cbbd5f194d8f6a9d7b524b0f7a8

comment:4 Changed 8 years ago by Vickie Lynch

Refs #5133 test fails on snowleopard so remove

Changeset: 596afe7cc9d381fae2506fdfa3acf75d60f57b4b

comment:5 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Removed tied variable dependence

  1. Errors reported when variables are tied are way too big
  2. Added constraints to restrict range for the variables
  3. Default now is to NOT calculate variances( Used complex tied formula)
  4. Improved initial parameters a bit.
  5. Updated test programs to reflect new values.
  6. Improved derivatives in the case (co)variances were calculated.
  1. Added a new column to the output table for IntegratePeakTimeSlices to list the specID's used to calcualte the integrated intensities. Changeset: 2563eb1a7ae41777d7ee810faa37d65df5ad66da

comment:6 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Removed tied variables to get sensible errors

  1. Errors reported when variables are tied are way too big
  2. Added constraints to restrict range for the variables
  3. Default now is to NOT calculate variances( Used variables tied with a complex formula)
  4. Improved initial parameters a bit.
  5. Updated test programs to reflect new values.
  6. Improved derivatives in the case (co)variances were calculated.
  1. Added a new column to the output table for IntegratePeakTimeSlices to list the specID's used to calcualte the integrated intensities. Changeset: 98b8459ce1b2dcc18f12764a5cb8bddec15fde35

comment:7 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Added IntegratePeakTimeSlices Test program

Changeset: 51990145e93ad4af2ddc17e0733579e6779e948e

comment:8 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Eliminated 2 tests because of snowLeopard seg fault

Changeset: bf881e97ae0f91ad87095ecf543cb0c020d4d020

comment:9 Changed 8 years ago by Vickie Lynch

Refs #5133 Test working again

Changeset: c0becbb3f503cb80dd30a2b3acbea6bbf2e07545

comment:10 Changed 8 years ago by Vickie Lynch

Refs #5133 need to fix sigma; remove from test

Changeset: 18627b5b5a3f2cbbd5f194d8f6a9d7b524b0f7a8

comment:11 Changed 8 years ago by Vickie Lynch

Refs #5133 test fails on snowleopard so remove

Changeset: 596afe7cc9d381fae2506fdfa3acf75d60f57b4b

comment:12 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Removed tied variable dependence

  1. Errors reported when variables are tied are way too big
  2. Added constraints to restrict range for the variables
  3. Default now is to NOT calculate variances( Used complex tied formula)
  4. Improved initial parameters a bit.
  5. Updated test programs to reflect new values.
  6. Improved derivatives in the case (co)variances were calculated.
  1. Added a new column to the output table for IntegratePeakTimeSlices to list the specID's used to calcualte the integrated intensities. Changeset: 2563eb1a7ae41777d7ee810faa37d65df5ad66da

comment:13 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Removed tied variables to get sensible errors

  1. Errors reported when variables are tied are way too big
  2. Added constraints to restrict range for the variables
  3. Default now is to NOT calculate variances( Used variables tied with a complex formula)
  4. Improved initial parameters a bit.
  5. Updated test programs to reflect new values.
  6. Improved derivatives in the case (co)variances were calculated.
  1. Added a new column to the output table for IntegratePeakTimeSlices to list the specID's used to calcualte the integrated intensities. Changeset: 98b8459ce1b2dcc18f12764a5cb8bddec15fde35

comment:14 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Added IntegratePeakTimeSlices Test program

Changeset: 51990145e93ad4af2ddc17e0733579e6779e948e

comment:15 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Eliminated 2 tests because of snowLeopard seg fault

Changeset: bf881e97ae0f91ad87095ecf543cb0c020d4d020

comment:16 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Moved most tied parameters to the end

Changeset: 8ed929f5810dd3475491a4095fcd57ab57238ee7

comment:17 Changed 8 years ago by Ruth Mikkelson

  • Owner changed from Vickie Lynch to Ruth Mikkelson
  • Status changed from accepted to assigned

comment:18 Changed 8 years ago by Ruth Mikkelson

  • Status changed from assigned to accepted

comment:19 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Moved most tied parameters to the end

Changeset: 8ed929f5810dd3475491a4095fcd57ab57238ee7

comment:20 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:21 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Eliminated variables tied to other variables

Changeset: 7a2cf60011c168d032586b5fb1d328dfbb0d0784

comment:22 Changed 8 years ago by Ruth Mikkelson

Refs #5133. Fixes to get test values correct

Changeset: 18a10f0a6659f18f04c69a096b4969eee2b00801

comment:23 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Elim warnings. Hope to fix link error

Changeset: 71233998bc448d898afd6036db2df50a6054d2c6

comment:24 Changed 8 years ago by Russell Taylor

Re #5133. Fix linker error on Windows.

Changeset: bf1425dbe99627797a1d3343bb41cd575aab9031

comment:25 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Attempt to find XP32 test differences

Changeset: b9f2ca790df1342ea99c3f8934ba8caa8a0db71e

comment:26 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Debug print to detect problem

Changeset: d9890cc566f1554260121bd623703536f63bd8ba

comment:27 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Eliminated compiler error( sorry)

Changeset: 347e76828731b88319262b81aa0fca43ccb164e4

comment:28 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Removed test for now

Changeset: dd1c9007bf490dd429ea4a69ea142e5329293927

comment:29 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Attempts to get test on X32 to work

Changeset: 0b8020862236d0b81fa874388877823dc78c661a

comment:30 Changed 8 years ago by Ruth Mikkelson

Refs #5133 More debug prints to find problem

Changeset: 683ef6c9720bd880fa48db8b7b318acbde9b434f

comment:31 Changed 8 years ago by Ruth Mikkelson

Refs #5133 More debug prints to get problem back

Changeset: e583cf11189bd16b1ef42fa10c075d7fba27957e

comment:32 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Disabling debug prints to get error back

Changeset: 199dff873a51e2e45b4af21047830bfa4c9a6fcd

comment:33 Changed 8 years ago by Ruth Mikkelson

Refs #5133 Added a few more prints to see things get fixed again

Changeset: 69ead3d0ebb811463f6f0c85e6e3cdfdbe85c8ca

comment:34 Changed 8 years ago by Ruth Mikkelson

Refs #5133 readded prints to see if X32 test results now match again

Changeset: fc9d8704ae8d61c5e2f59104d34d9fe69f5ca100

comment:35 Changed 8 years ago by Ruth Mikkelson

Refs #5133. Moved variables, commented out debug prints

To get to work on X32

Changeset: 4f289cbd82a981d06f1be133a71bbb6ce90807fc

comment:36 Changed 8 years ago by Ruth Mikkelson

Refs #5133. Hopefully this is it.

Changeset: 5d604fa4028a09285ea82a31f0e78b58c4c70be3

comment:37 Changed 8 years ago by Ruth Mikkelson

Refs #5133. Eliminated debug prints, added new test

SCDCalibratePanels may now work.

Changeset: 04398ca1c77f608c5fcf525b535bf2884063c434

comment:38 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:39 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:40 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to closed

Integrated peaks agree well with IntegratePeaksMD.

comment:41 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5979

Note: See TracTickets for help on using tickets.